i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deskbar: Fix open prefs window incorrectly sets Deskbar window state.

Browse Source 
Set window location but do not Invoke() when opening prefs window.
We do not want the Deskbar window location to change on open/show
prefs window, only when you change the preference.

The root problem here is that we currently do not support horizontal
mini-mode in Deskbar preferences, only vertical. Consequently, opening
the prefs window switches Deskbar into vertical mini-mode when in
horizontal mini-mode. Leave the state alone so this doesn't happen.

Change-Id: Ife00e02f4bc16344fed47d23b9d768aa46b8d7f7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11524
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
(cherry picked from commit 6674947bb98ba64da5af9d5de6f894850a194b98)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11533
This commit is contained in:
John Scipione
2026-08-15 03:10:30 +00:00
committed by waddlesplash
parent c12c2d4488
commit 446139c354
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/deskbar/PreferencesWindow.cpp
+1 -5
View File
@@ -242,8 +242,6 @@ PreferencesWindow::PreferencesWindow(BRect frame)
.SetInsets(B_USE_WINDOW_SPACING)
.End();
fWindowLocation->Invoke();
BMessage windowSettings;
BPoint where;
if (_LoadSettings(&windowSettings) == B_OK
@@ -330,10 +328,8 @@ PreferencesWindow::Show()
// refresh window location from settings
desk_settings* settings = static_cast<TBarApp*>(be_app)->Settings();
if (settings != NULL) {
if (settings != NULL)
_SetWindowLocation(settings->vertical, settings->left, settings->top, settings->state);
fWindowLocation->Invoke();
}
_UpdateButtons();