PVS V575: strange values passed to well known functions

Change-Id: Id6008d93777f860d0b341bcd012fe6f86c99cf35
Reviewed-on: https://review.haiku-os.org/c/1610
Reviewed-by: Stephan Aßmus <[email protected]>

src/bin/setmime.cpp

@@ -723,8 +723,8 @@ MimeType::_PurgeProperties()
 	delete fBigIcon;
 	fBigIcon = NULL;
 
-	fVectorIcon = NULL;
 	free(fVectorIcon);
+	fVectorIcon = NULL;
 
 	fExtensions.clear();
 	fAttributes.clear();

src/kits/package/hpkg/PackageFileHeapWriter.cpp

@@ -162,7 +162,7 @@ private:
 			return fUnusedBuffers.RemoveItem(fUnusedBuffers.CountItems() - 1);
 
 		void* buffer = malloc(fBufferSize);
-		if (buffer == NULL && !fBuffers.AddItem(buffer)) {
+		if (buffer == NULL || !fBuffers.AddItem(buffer)) {
 			free(buffer);
 			throw std::bad_alloc();
 		}

src/system/libroot/os/driver_settings.cpp

@@ -457,8 +457,6 @@ load_driver_settings_from_file(int file, const char *driverName)
 				// everything went fine!
 				return handle;
 			}
-
-			free(handle);
 		}
 		// "text" might be NULL here, but that's allowed
 		free(text);

src/tools/fs_shell/driver_settings.cpp

@@ -423,8 +423,6 @@ load_driver_settings_from_file(int file, const char *driverName)
 				// everything went fine!
 				return handle;
 			}
-
-			free(handle);
 		}
 		// "text" might be NULL here, but that's allowed
 		free(text);