- Did not see his comments before pushing my previous change.
- clear owning flag when passed value is NULL.
Change-Id: I493973aff2b107785c3734847c85a52f0f9da360
Reviewed-on: https://review.haiku-os.org/c/1443
Reviewed-by: waddlesplash <[email protected]>
- Keep track if the softc was allocated externally or not.
- Only try to deallocate it if it was allocated internally.
Do not try to free the softc if we were not the ones allocating it.
- Avoid a double free on consecutive calls to device_set_softc.
Change-Id: Ibb38e54e9dfd2a80dbb53920970bead626da8ba1
Reviewed-on: https://review.haiku-os.org/c/1441
Reviewed-by: Adrien Destugues <[email protected]>
include all supported video modes. Fixes#4166.
Note that this change will probably show several weird resolution is some
configurations. They are all valid resolutions but are not commom so we need
a way to filter those out.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42600 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Keep track of the correct number of initial modes available.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42438 a95241bf-73f2-0310-859d-f6bbb57e9c96
Note that the reference to GCC4 Vorbis Tools is also broken but I did not fix
it as there is no GCC4 vorbis Tools package available where all the other
optional packages are.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40043 a95241bf-73f2-0310-859d-f6bbb57e9c96
instead of getrusage.
- Thanks François for insisting on this. :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34133 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Untested, but should work (will test it when I get home later today).
- This is my first attempt at adding something for compatibility reasons. Let
me know if something in wrong.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34091 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Implements STARTTLS support to the SMTP add-on.
- Untested, but implementation matches RFC.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33012 a95241bf-73f2-0310-859d-f6bbb57e9c96
make it more interesting in this respect.
- Uses node monitors to react to external changes. Updates the window
contents accordingly.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32912 a95241bf-73f2-0310-859d-f6bbb57e9c96
eventually as, right now, we just handle it as normal multiple matches.
- Improved error reporting for CDDB query commands.
This should fix#4103.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32423 a95241bf-73f2-0310-859d-f6bbb57e9c96
Is it intentional that Horizontal Frequency is reported as being KHz while
Vertical Frequency is reported as being Hz?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32104 a95241bf-73f2-0310-859d-f6bbb57e9c96
manifest from it. This is a common condition on the first run.
- Added a comment about this.
This fixes ticket #2133.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31650 a95241bf-73f2-0310-859d-f6bbb57e9c96
non-ambiguous names (as pointed out by Ingo).
- This file has a lot of code that is Haiku only and is not in the original
ntfs-3g code. maybe we should try to clean this up and merge the changes
upstream.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31592 a95241bf-73f2-0310-859d-f6bbb57e9c96
size of wchar was 16 bits, which was not true anymore after recent changes.
- Considering the changes were inside libntfs, which is 3rd party code, I am
not sure this is the correct way to apply this fix (if you have a better
idea, let me know.
- This fixes bug #4075.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31589 a95241bf-73f2-0310-859d-f6bbb57e9c96
Note that this does not fix the fact that the volume name can be in the bpb or
in a diri. The dosfs_identify_partition() only returns the label in the bpb so
more usually than not it will show one name in Tracker's mount menu and a
different name when mounted.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30837 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Added the server to Bootscript.
This closes ticket #3446.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30781 a95241bf-73f2-0310-859d-f6bbb57e9c96
second we should use 1000 as a factor and not 1024. Thanks Fredrik Ekdahl
for the heads up.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30780 a95241bf-73f2-0310-859d-f6bbb57e9c96
the "files" is, the actual bitrate of the CD is higher because of error
correction).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30749 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Added it to the image.
- Anyone wants to come up with an icon for it? :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30736 a95241bf-73f2-0310-859d-f6bbb57e9c96
for the third time. :P
- Implement CDDBServer class.
- Include relevant CDDB commands.
- Initial processing of CDDB data. Change device name.
This is close to be complete but I hit some cdda-fs bugs that need to be fixed
before I will finish this.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30703 a95241bf-73f2-0310-859d-f6bbb57e9c96
expected now.
- Yeah, yeah... Style guidelines. I just followed what is used throughout
this file. :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30630 a95241bf-73f2-0310-859d-f6bbb57e9c96
Not included in the image yet but I think it may be a good idea to include it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30447 a95241bf-73f2-0310-859d-f6bbb57e9c96
deleted) try to handle it as if there was no preferred app set and if a
handler for its type exists, use it to open the file.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30438 a95241bf-73f2-0310-859d-f6bbb57e9c96
BPath blah("blah");
printf("%s\n", blah.Path());
It seems that in R5 it would print "blah" (untested as I don't have R5 anymore, but this code definitelly used to work). And in Haiku it prints "/currrent/path/blah".
This fixed bug #3187.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29326 a95241bf-73f2-0310-859d-f6bbb57e9c96
http://www.freelists.org/post/haiku-development/Runtime-loader-problem
The problem seems to be related to loading/unloading add-ons linked against the
recent OpenSSL. Linking the E-mail preferences against the SSL libraries (when
USE_SSL is enable) fixes this as the SSL libraries are not unloaded then.
I am still investigating this but will have no more time this week so I am commiting this workaround until I look at it again.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29320 a95241bf-73f2-0310-859d-f6bbb57e9c96
This actually show a bug in BPopUpMenu. It seesm to think that its size
includes the arrow at its right size and so it draws the menu item
string over it. Stippi?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29285 a95241bf-73f2-0310-859d-f6bbb57e9c96
- This means that buffers with a initial size of 0 work now.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29006 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Fixed some styles violations.
- Changed signature to include the executable name.
Preparation for the new code coming.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28935 a95241bf-73f2-0310-859d-f6bbb57e9c96
- This has the side effect that now it actually works.
- This also indirectly fix BNetEndpoint usage of BNetBuffer.
- Added DynamicBuffer (the underlying buffer implementation) to the Jamfile.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28928 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Default buffer size is now set to 1 instead of 0, which would cause the
construction without a given size to fail.
- Added copy constructor.
- Changed _GrowToFit() to have a boolean parameter to indicate if we want
to resize the buffer to an exact size. Used by the copy constructor.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28924 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Will be used by the new (R5 compatible) NetBuffer class.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28918 a95241bf-73f2-0310-859d-f6bbb57e9c96
This change will make directories like the downloads folder get its correct
special icon even if it is a link to a another directory. The destination
directory also gets the icon which makes it easy to identify special
directories even in other partitions.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28730 a95241bf-73f2-0310-859d-f6bbb57e9c96
selected item which does not make much sense. Disabled the checkmark.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28201 a95241bf-73f2-0310-859d-f6bbb57e9c96
constructiuon. Thanks Rene for reminding me that BMimeType actually has a
InitCheck() method. :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27224 a95241bf-73f2-0310-859d-f6bbb57e9c96
retrieve CDDB information. This is coming as soon as I have real time (as
opposed to some minutes during lunch) to work on it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27200 a95241bf-73f2-0310-859d-f6bbb57e9c96
consistency.
All well-known directories in the home dir ("mail", "people", "config") are all
lowercase. The only exception was the "Downloads" one.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27199 a95241bf-73f2-0310-859d-f6bbb57e9c96
view of the small data section and the outside view.
Long version:
AttributeIterator is a higher level class designed to make it easy to iterate
through attributes in the small data section. The first attribute in the small
data section is the special "name" attribute that is used to reconstruct the
node path when you only have a node handy. As this attribute is not user
visible nor user modifiable (except by changing a node name of course), it is
considered a special attribute so the AttributeIterator class ignores it and
starts iterating from the second attribute on.
As opposed to this, internally the Inode class accesses the small data section
directly without using the AttributeIterator class so whenever it indexes items
in the small data section, it takes into account the special "name" attribute.
This creates a off-by-one relationship between those 2 representations and this
was a problem because whenever the small data section changed, all iterators
had to be updated (through a call to AttributeIterator::Update() having an
index parameter that represented the outside view and not the AttributeIterator
view, so iterators would not be adjusted correctly and the end result is that
every other attribute was not removed from the index. This would cause all
types of havoc with indexes, the simplest one being that entries in indexes
would point to non-existing nodes.
Ingo, pleased now? ;)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27196 a95241bf-73f2-0310-859d-f6bbb57e9c96
This may be masking out a different bug.
- This fixes part of bug #2614. It may even fix all of it but I have to
test.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27180 a95241bf-73f2-0310-859d-f6bbb57e9c96
be able toreproduce it before.
- Don't try to access methods in a NULL object. :)
- This fixex bug #1128.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27153 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Could not find a suitable icon for multipart files. Ideas?
- Added missing descriptions and fixed the image descriptions.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27147 a95241bf-73f2-0310-859d-f6bbb57e9c96
for a specific MIME type.
- Attribute menus now display a hierarchy with type and supertype attributes.
This looks a bit ugly but mostly because not all types and supertypes have icons and descriptions. Anyone up to do a MIME database cleanup? :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27125 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Do not save or load attributes in the protected namespace.
Now cddb_server has everything it needs.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27120 a95241bf-73f2-0310-859d-f6bbb57e9c96
Usefull when, for some reason, you already have an fd around.
- Changed the non-parameter version to set the fd and call the parametrized
version.
- CD-Text reasing is expensive (takes up to 4 seconds on my machine) so now it
is only done if this is the first time the CD is inserted (technically, if it
errors out when trying to open the attributes file for the CD). With this, the
first time I mount a CD still takes 4 seconds, but consecutive mounts happen
almost instantaneously.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27109 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Includes all relevant handling of CDDA exported attributes so you guys can
see where I am going with this.
CDDB handling (including server connection, request and response parsing)
will come up next. In the future we will also have a configuration panel
and a Deskbar replicant for controlling it.
Do we really have to edit the Jamfile in the parent dir to get something
building with our build system?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27096 a95241bf-73f2-0310-859d-f6bbb57e9c96
attribute name as input. Handy for whyen we do not have an Attribute object
around.
- Made the non-static version fall back to the static version.
- Also check for the protected namespace when creating attributes. For
consistency, we should also not be able to create attributes in this
namespace.
- Added some new style violations. ;)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27082 a95241bf-73f2-0310-859d-f6bbb57e9c96
now has a IsProtectedNamespace() member.
- All CD:* attributes can not be directly edited by the user as they are
internally maintened by the add-on itself.
- Style updates (thanks Stefano!)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27080 a95241bf-73f2-0310-859d-f6bbb57e9c96
cddblinkd) to know if they should lookup the CD or not. It will be true
unless:
1 - The CD has CD-Text information.
2 - The user (or a userland program) changed the Volume name.
3 - The user (or a userland program) changed any track names.
- Moved (again) attribute creation to before the stored attributes are read. As
attribute operations happen in memory in cdda, we don't need to care about
the IO cost and this way it is more in line with all the other attributes
created.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27079 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Only adds it if it does not exist yet.
This does not change anything but makes more sense anyway.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27073 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Now marking emails as spam through the Mail app also works.
Still need to fix the Match Header filter as it seems not to be working.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26991 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Tracks are now called "Track XX" instead of "XX".
- We need no stinking TLAs! :)
Next step, porting CDDBLinkD to Haiku.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26974 a95241bf-73f2-0310-859d-f6bbb57e9c96
interfaces. This fixes bug #2227.
Note that when the SATA interface is in AHCI mode it is still failing
due to what seems to be a device manager problem. I will open a separate
bug for it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26902 a95241bf-73f2-0310-859d-f6bbb57e9c96
