Commit Graph
100 Commits
Author SHA1 Message Date
Stefano Ceccherini ab8e333337 Removed trailing 'OpenBeos' from translators's names, to be consistent with the rest. Anyone knows why we have two TIFF translators in the tree?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17696 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-01 20:21:51 +00:00
Stefano Ceccherini 68c442e5c2 small cleanup, removed now unneeded hack
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17695 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-01 20:03:20 +00:00
Stefano Ceccherini 980e1e66ca fixed build on linux
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17694 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-01 19:59:23 +00:00
Stefano Ceccherini b9af5bfa5c - Fixed the recently introduced bug where menus would open again once closed. -Now hitting ESC will close the menu. - Reverted to the other variation of GetMouse() as Axel's advice
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17654 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-30 19:14:54 +00:00
Stefano Ceccherini c1dd282b9b Fixed some bugs in StealFocus, RemoveFocus and SetStickyMode
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17614 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-28 08:50:52 +00:00
Stefano Ceccherini cd39decc44 Added a filter to MenuField, so that mousedown messages caught by the inner menubar are redirected to the BMenuField's MouseDown() like happens on beos. That way we can track and invalidate correctly. Implemented Show/HidePopUpMarker
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17613 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-28 07:48:53 +00:00
Stefano Ceccherini 848b89034e More hacks to BWindow's mousedown handler, to fix some problems with menus. Fixes bug 610 among other things. Note: I don't like this code so much, but apparently BeOS handles it in a similar way. I accept suggestions on how to improve this.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17606 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-27 13:00:35 +00:00
Stefano Ceccherini e061d1bae5 an eventually opened menu is now quit in BWindow::DispatchMessage()
before sending a B_MOUSE_DOWN message to any other view. This fixes bug 
594 for real and another bug in BMenuBar.  BMenuBar tracking will also 
be simplified a bit because of this. Install items to a NULL window on 
Show() as does R5 (although I don't know why yet). 


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17605 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-27 09:57:14 +00:00
Stefano Ceccherini 03f2d7791e Switched back to the GetMouse variation which does NOT check the message
queue, should fix bug 594 and not risk of losing clicks. SetStickyMode() 
calls StealFocus() to give the chance to be keyboard-navigated to menus. 
Added an extra (temporary) InvalidateLayout() because some items weren't 
added in 
some cases (Tracker's attributes menu for example)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17599 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-26 18:13:38 +00:00
Stefano Ceccherini 73f99cd6ae reverted axel's change to menu, which introduced some other problems, and I can't reproduce that problem anymore. Axel, can you verify, please ?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17598 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-26 17:28:18 +00:00
Stefano Ceccherini a7dc54697c The drawstate is now synched when the recording of a BPicture starts. Some reordering of the function calls, implemented B_PIC_SET_BLENDING_MODE, some other cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17580 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-24 19:10:15 +00:00
Stefano Ceccherini b0f89f914d Fixed the problem mentioned in bug 484, some cleanups, implemented
BMenu::InvokeItem() more correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17519 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-20 22:36:38 +00:00
Stefano Ceccherini 2b73985eb0 renamed class members to fit our guidelines (more or less)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17518 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-20 22:10:00 +00:00
Stefano Ceccherini f711110191 Refactored the AddItem mechanism. Now the private _AddItem() method doesn't lock the looper or invalidate the layout anymore, which is done by the caller. This way AddList is much more efficient.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17502 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-19 08:03:11 +00:00
Stefano Ceccherini f190c6255e minor cleanup, adjusted copyright
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17456 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-14 19:50:42 +00:00
Stefano Ceccherini f56a708cde FontSizeMenu marks the correct item on AttachedToWindow. Fixes bug 565
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17428 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-11 22:21:48 +00:00
Stefano Ceccherini a73a27510a more cleanups. There is now a MenuSettings class which handles settings in a central way. More code simplification
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17427 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-11 21:31:56 +00:00
Stefano Ceccherini fdd142c9ed Removed the Update() methods. Created a new class AutoSettingsMenu from which every menu class inherits. It gets the new settings on AttachedToWindow() automatically
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17426 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-11 20:23:38 +00:00
Stefano Ceccherini 1655525f95 Check the lock, some cleanups. Fixes some crashing bugs which didn't show up before for pure luck
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17418 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-10 20:15:36 +00:00
Stefano Ceccherini c8773f97a0 Invalidate less in BMenuBar::FrameResized() and a bit more in _BMCMenuBar_::FrameResized(), removed unused _BMCItem_
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17417 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-10 19:29:35 +00:00
Stefano Ceccherini f4ff3be7a4 Fixed the problem mentioned in the previous commit: BMenuBar::FrameResized() now invalidates the view. We might be smarter and try to only invalidate part of it, though
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17408 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-09 22:07:25 +00:00
Stefano Ceccherini 925479d7b3 Added a new method RelayoutIfNeeded(), which does the real Layout invalidation, it's called by menubar and menu. This fixes the menufields not being resized. Note that a problem still remains, will be fixed shortly (hopefully)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17405 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-09 21:48:51 +00:00
Stefano Ceccherini 5a5960830d some changes, improved double buffered mode, it still has some problems, though
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17374 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-08 20:13:35 +00:00
Stefano Ceccherini 07cc05136f Implemented the BView::DrawPictureAsync() version which accepts a filename, not tested
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17373 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-08 20:12:52 +00:00
Stefano Ceccherini 63b7888854 BMenu::InvalidateLayout() should only sets a variable, the real invalidation is done on Draw() or AttachedToWindow() (like on R5). This fixes bug 567 (at least the crash in HotEdit)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17356 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-07 19:58:07 +00:00
Stefano Ceccherini 47b3e74e2d reduced the padding for the border, which is only 2 pixels per side, not 4
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17345 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-05 19:56:33 +00:00
Stefano Ceccherini dab6094902 sorry, this wasn't correct
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17344 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-05 19:55:49 +00:00
Stefano Ceccherini 71c3e4ad7d Fixed bug 516, worked some more on AutoResize() (which is still not correct, but improves the situation, looks like bug 161 wasn't completely fixed yet)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17342 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-05 18:08:35 +00:00
Stefano Ceccherini 927a84f8f6 mkindex wasnt' built, so install-haiku failed on systems different than beos. Now it fails because it doesn't know what BEOS:APP_SIG is. I have no idea how to fix that problem, please someone have a look.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17290 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-01 22:32:23 +00:00
Stefano Ceccherini cc8ef734e9 Fixed BDragger popup again, was broken after latest changes to BMenu/BPopupMenu
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17289 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-05-01 21:45:48 +00:00
Stefano Ceccherini 5e9bdfc4d7 Chart doesn't hang on quit anymore (bug 431)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17283 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-30 21:26:16 +00:00
Stefano Ceccherini 4436b7269d Menuitems are layoutted better, fixing bug 526
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17282 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-30 20:24:30 +00:00
Stefano Ceccherini 7dce0c352e Removed unused stuff
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17257 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-28 20:22:28 +00:00
Stefano Ceccherini 7af215cc5f fixed a small problem introduced with the last commit
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17240 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-26 10:20:47 +00:00
Stefano Ceccherini 05e515d56c hopefully improved menu tracking. Among other things, this fixes bug 461
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17204 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-22 17:56:21 +00:00
Stefano Ceccherini 59d1b7be9d It's a good idea to snooze AFTER we've checked the possible exit conditions
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17189 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-21 11:33:02 +00:00
Stefano Ceccherini 48688dcd5f Fixed a bug in menu tracking: in some cases you had a goal of 1 pixel when trying to enter a submenu ( http://flickr.com/photos/johndrinkwater/131805244 )
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17181 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-20 20:56:57 +00:00
Stefano Ceccherini f274fa345d click_to_open now is always true, and cannot be disabled
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17175 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-19 20:19:51 +00:00
Stefano Ceccherini b03deb09db Menu settings are now handled by the app_server. As a result, changing them does something, although they aren't saved to disk yet. 'click_to_open' is not checked anymore, because it was useless anyway, I'll remove it from the Menu preflet too.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17174 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-19 20:04:19 +00:00
Stefano Ceccherini f90a951e32 The previous commit was obviously incorrect, as the window wasn't updated anymore.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17170 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-19 08:23:38 +00:00
Stefano Ceccherini 422ce5d4bc the synchronous version of BSlider::MouseDown() now discards old message events
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17169 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-18 21:19:53 +00:00
Stefano Ceccherini 1b5b2e4c35 MenuItems don't flicker anymore when a submenu opens (fixes bug 484). Implemented popupmenu's 'clickToOpenRect' feature, used by tracker's dirmenus, for example (fixes bug 523
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17168 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-18 20:32:10 +00:00
Stefano Ceccherini 1da0b2498f Fixes part 2 of bug 472
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17157 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-17 17:48:05 +00:00
Stefano Ceccherini efdd958617 BSlider locked the looper and never unlocked it anymore. Was the cause of bug 406
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17154 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-17 14:17:29 +00:00
Stefano Ceccherini 4697016070 Lowered the delay in menus after which they don't switch to sticky mode, should fix bug 491, although its not really a bug
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17153 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-17 14:13:08 +00:00
Stefano Ceccherini 2420234dff BTextView::AutoResize() wasn't still completely correct, causing bug 464
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17152 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-17 14:09:32 +00:00
Stefano Ceccherini 415c63bee2 PopUpMenus didn't respect the openanyway setting (sticky mode), they always set it. And even in that case, they weren't working correctly. This should fix bugs 463 and 476. This might not work if click to open isn't selected in the menu prefs, though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17136 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-15 16:57:51 +00:00
Stefano Ceccherini ce1efe4ce6 forgot to commit this changed header, sorry
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17135 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-15 12:55:39 +00:00
Stefano Ceccherini 36aa2198b7 Some more changes, fixed bug 487, added a small hysteresis so menus could be more nice to navigate, some corrections in popupmenu
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17134 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-15 12:42:34 +00:00
Stefano Ceccherini 0e0b8fd554 more fixes
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17104 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-12 11:25:59 +00:00
Stefano Ceccherini 7d550b53a0 and there, the usual forgotten stuff
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17096 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-11 20:53:11 +00:00
Stefano Ceccherini 2191a09a93 big improvements for menus. The tracking is in many ways on par with r5, except for a few things, like diagonal movement and that grandparent bug
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17095 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-11 20:20:41 +00:00
Stefano Ceccherini 357433e049 more subtle fixes for menubar
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17056 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-10 19:52:47 +00:00
Stefano Ceccherini 337ab7d069 Align the textview to the correct alignment if it resized itself.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17055 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-10 19:29:13 +00:00
Stefano Ceccherini 679d063bdc Looks like bug 419 wasn't fixed by previous commit. Let's see if this does.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17050 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-08 11:19:00 +00:00
Stefano Ceccherini 791b9c2141 in case DEBUG is defined, BLooper don't use the benaphore style lock. Useful for debugging
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17045 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-07 19:09:45 +00:00
Stefano Ceccherini 9c5c552dd6 more fixes
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17043 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-07 17:44:02 +00:00
Stefano Ceccherini bf5d7973b9 Obviously I put in the usual 'untested last minute change' which broke everything. Should be fixed now.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17042 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-07 17:24:14 +00:00
Stefano Ceccherini c51421cc0b implemented sticky mode. Let's see how many complaints because it's not perfect at all. Under qemu it's super crappy btw
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17041 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-07 16:52:37 +00:00
Stefano Ceccherini 77e45e57aa Corrected previous commit. Thanks to Axel for noticing
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17017 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-05 19:40:26 +00:00
Stefano Ceccherini cb8bdc4eda Window's destructor should acquire the menu sem, not delete it. Could help fixing bug 422
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17016 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-05 19:32:54 +00:00
Stefano Ceccherini e21b037f2b Should fix bug 326
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17015 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-05 19:15:54 +00:00
Stefano Ceccherini 02c491fd7e small cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17014 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-05 19:01:41 +00:00
Stefano Ceccherini 29c407a371 Fixed menus in case the window was hidden (VLC, StyledEdit). This is just a quick fix and will be changed later. Thanks to John Drinkwater for testing
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17008 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-04 14:31:46 +00:00
Stefano Ceccherini abb7ab0861 Check if we have a window in BTextView::DrawLines(). This should fix bug 383. We might remove it from there and check in the caller instead, as DrawLines is a private function (maybe add an ASSERT() call)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16999 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-04 07:46:09 +00:00
Stefano Ceccherini 195f58ddbb BMenu::_AddItem() keeps the looper locked for the whole time, other changes: let's see if this fixes that bug
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16990 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-03 19:50:16 +00:00
Stefano Ceccherini e90bed06b1 Fixed vlc menubars
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16975 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-02 22:31:04 +00:00
Stefano Ceccherini a2b0a7ac3e Avoid tracking the menubar if it's tracking already
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16974 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-02 21:47:46 +00:00
Stefano Ceccherini 265242ecfa Patch by barber which actually make menu color changes work, plus some other changes. Note that this shows some problems in how BMenuItems are drawn (wrong colors)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16963 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-02 08:11:53 +00:00
Stefano Ceccherini 9deb82dfc0 If the popup was asynchronous, the window menu semaphore was never resetted
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16962 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-04-02 07:39:13 +00:00
Stefano Ceccherini 262a2483e2 I woulnd't say the classical last words... but I seem to have fixed latest crashes...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16943 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-31 20:13:41 +00:00
Stefano Ceccherini f2e9b063a0 This small change could even fix some big problems with menus... unfortunately I can only reproduce them in vmware, and not in qemu
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16940 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-31 09:37:59 +00:00
Stefano Ceccherini 76b895fb5c Vertical alignment of bitmaps and shortcut char is calculated more correctly (hopefully). Should fix bug 352
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16921 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-29 11:23:31 +00:00
Stefano Ceccherini 793fde40eb This should fix some problems I experienced later. At least, I can't reproduce them anymore
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16920 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-29 10:42:54 +00:00
Stefano Ceccherini 35beeaa99f Minor improvements
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16916 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-28 20:22:15 +00:00
Stefano Ceccherini 81401e08e7 Commented out some parts which caused big troubles
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16915 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-28 19:48:06 +00:00
Stefano Ceccherini 4185bd8b34 Hopefully simplified BMenu/BMenuWindow relationship and made it more robust.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16910 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-28 13:06:47 +00:00
Stefano Ceccherini 9913366fe7 Reset fAttachAborted otherwise menus never get filled after they have been interrupted once.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16908 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-28 06:44:39 +00:00
Stefano Ceccherini 6aa12747cd Stupid me. ConvertToScreen() isn't needed, and I should read more carefully my own code
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16901 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-27 21:50:35 +00:00
Stefano Ceccherini ed49f4afcd Improved OkToProceed(), removed unused file
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16900 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-27 21:46:19 +00:00
Stefano Ceccherini f356aedc02 Implemented BMenu::OkToProceed() and used it correctly in BMenu::AttachedToWindow(). For some reason, though, I had to comment it out partially as something is wrong. I haven't debugged, though
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16899 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-27 19:43:05 +00:00
Stefano Ceccherini 7abe70f1b4 Hopefully cleaned up a bit the locking in BMenu::_show()/_hide()
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16867 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-23 15:33:28 +00:00
Stefano Ceccherini 68ead3ea06 BLooper uses a benaphore style lock, should save some cycles. I hope this wasn't left out on purpose
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16864 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-22 21:56:31 +00:00
Stefano Ceccherini 37cf3d970d Avoid attaching a menu to the BMenuWindow when not needed
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16863 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-22 21:07:35 +00:00
Stefano Ceccherini b781587aff BMenuItems are invoked if needed when they are child of a menubar. Fixes bug 343
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16862 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-22 20:52:25 +00:00
Stefano Ceccherini b80eb9d443 Partially reverted axel's change, because it brings more troubles than benefits (menus lock when they reuse the supermenu's menuwindow). I'll try to resolve the various problems in another way. Some cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16861 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-22 20:47:52 +00:00
Stefano Ceccherini 7a2c9b35cd Reverted to r16487 due to various problems. I'll recommit the code once it's fully working.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16850 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-21 16:06:46 +00:00
Stefano Ceccherini ebaeaa1224 BMenu::InvalidateLayout() now just marks the cached layout as invalid, instead of recalculating it. This results in less computations. Reorganized the layout calculation due to that. Now it's done once in AttachedToWindow(), and in Draw(), only if needed
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16848 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-20 21:49:11 +00:00
Stefano Ceccherini 65b4fb8ab1 Check if alt is the command key on BMenu::AttachedToWindow instead of doing it for every BMenuItem::Draw()
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16847 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-20 20:20:29 +00:00
Stefano Ceccherini 98b5c6b926 Sorry, this was just a test and wasn't meant to be committed.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16816 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-16 11:15:42 +00:00
Stefano Ceccherini 698e0e3fa7 draw shortcut char and bitmaps one pixel higher
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16815 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-16 11:11:28 +00:00
Stefano Ceccherini 21f9f047fa Don't resize items if not needed, small change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16810 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-15 20:44:23 +00:00
Stefano Ceccherini f6e3e0a259 Redraw the text when MakeResizable is called. Fixes bug 187
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16798 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-14 21:30:19 +00:00
Stefano Ceccherini c44a5bea8b Don't switch to I_BEAM cursor if the textview isn't editable nor selectable. Fixes bug 246 for real
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16797 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-14 21:02:39 +00:00
Stefano Ceccherini e3d0715523 Enlarged a bit the BMCMenuBar's frame, so that it's drawn more nicely
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16795 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-14 20:41:50 +00:00
Stefano Ceccherini 1fdb18f7dd BChannelControl::GetPreferredSize() is a pure virtual
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16794 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-14 20:41:04 +00:00
Stefano Ceccherini e78c06d170 Reverted change 16774 as stippi's wish. The offset should be ignored when drawing bitmaps, but it's obviously not, at least in some case.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16781 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-14 08:04:35 +00:00
Stefano Ceccherini 23467f07d9 BBitmap's constructor offsets the passed BRect to B_ORIGIN in case it isn't already. This fixes bug 301. Offset the rect in ChannelSlider too just in case.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16774 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-13 20:37:27 +00:00
Stefano Ceccherini deab92e7ed Minor changes, fixed a possible leak in Uninstall()
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16773 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-13 20:36:04 +00:00
Stefano Ceccherini 88ae0d494c Seems like BeBook lies on BTextView's autoresizing mode. The textview itself isn't resized, but only the textrect is. Fixes bug 161, but maybe it needs more work
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16770 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-03-13 19:51:15 +00:00