Commit Graph
100 Commits
Author SHA1 Message Date
X512 be3fde6d02 app_server: perform NULL check before use
Fixes #16610.

Change-Id: Ic377a2faef7279f607298b3b80bc44bc1c6aae36
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3401
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>
2020-11-20 18:24:48 +00:00
X512 529fedc75c Interface kit: Resize menu if invalidated.
Change-Id: I45a966b13be6953431a1176378e4ddc10920916b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2325
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: X512 <[email protected]>
2020-11-16 15:09:34 +00:00
X512 dad52bddc7 drivers/scsi_cd: set device name
Change-Id: I62b0a599ed2451a27069a2149ddc4e58384ed95f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3389
Reviewed-by: Jérôme Duval <[email protected]>
2020-11-15 19:58:40 +00:00
X512 1aef13ad6d bus_managers/pci: set legacy device name to driver name
Change-Id: Idf14da8f105ab7ed6ac78053acb344045d97306a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3388
Reviewed-by: Adrien Destugues <[email protected]>
2020-11-15 19:58:40 +00:00
X512 6fd2274306 app_server pointer/ownership cleanup: trivial changes
Split apart the work done in https://review.haiku-os.org/c/haiku/+/2695
in smaller, easier to review parts.

This commit contains self-contained/local changes that are unlikely to
cause problems.

Change-Id: Idae27ca440791423e3d090bcfe33f4cc83bbea3d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3174
Reviewed-by: Adrien Destugues <[email protected]>
2020-09-19 07:13:19 +00:00
X512 6aee9d6424 Tracker: fix count view border problem
Fixes #16439.

Change-Id: If936517a0ecfaba994f5d48fcc2fd159cb8ea11f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3093
Reviewed-by: waddlesplash <[email protected]>
2020-07-26 03:07:11 +00:00
X512 77912444b8 Tracker: fix ScrollIntoView
Same problem as in BListView::ScrollToSelection.

Change-Id: I1cd26190566b1808f47475c1499298b66549f024
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2312
Reviewed-by: Adrien Destugues <[email protected]>
2020-07-18 13:58:28 +00:00
X512 c3a6a6b6ee mime_db: add BPicture type
Change-Id: I69948b04e6c1b19165a51cd0eb999591da4efccb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2828
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2020-07-18 13:41:31 +00:00
X512 f27269a67d MediaPlayer: fix reporting wrong format
Now it allows to connect MediaPlayer video producer to differnt node in Cortex.

Change-Id: I7ee598ea64d10e8fa876259e7a4480a650a0e189
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3034
Reviewed-by: Adrien Destugues <[email protected]>
2020-07-18 13:25:09 +00:00
X512 36ef16bf08 BGradient: add Flatten, Unflatten methods
Change-Id: I861bab8ae19628d34297c294fd6ce3e5b6c82b34
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2827
Reviewed-by: waddlesplash <[email protected]>
2020-07-13 15:35:38 +00:00
X512 4399ec510d BPicture: add fill rule support
Change-Id: I068e1c2e8659f7b90c6d7c7331a8bb25ae343fe9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2922
Reviewed-by: Adrien Destugues <[email protected]>
2020-07-12 19:44:43 +00:00
X512 90ab1a44ad BPicture: add gradient support
Fixes #9680.

Change-Id: I0013326559cc40ff26cf7b44794c0b32aea832ba
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2829
Reviewed-by: Stephan Aßmus <[email protected]>
2020-07-12 19:44:43 +00:00
X512 d9d96260e0 BMenu: speed up deleting items
Fixes #16336.

Change-Id: Ie941f45f363f6fe94062fc3acb8bd3bb876c1f1e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2976
Reviewed-by: waddlesplash <[email protected]>
2020-07-04 16:49:55 +00:00
X512 fb44a1cd72 BMenu: fix memory leak in scripting
Change-Id: Ia283594a622f758189cc8280683a4e068ae1f3af
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2978
Reviewed-by: waddlesplash <[email protected]>
2020-07-02 19:26:49 +00:00
X512 cc30c791bd TV: fix scripting
Change-Id: I84e8f87ff7f84d0624bfea72c2e12d148a5a2562
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2959
Reviewed-by: waddlesplash <[email protected]>
2020-06-28 21:42:52 +00:00
X512 213e62a7a0 Input: fix MouseView drawing
BeginPicture/EndPicture do not save state so origin should be restored
after recording picture. BView::Draw use PushState internally so origin
is added and cause problem.

hrev54347 fixed behavior when recording picture so state change is
affected. It revealed #16317 bug.

Fixes #16317.

Change-Id: Iee69631ce83fea5ea73c99b492b8cf67d1b148c7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2960
Reviewed-by: waddlesplash <[email protected]>
2020-06-28 21:39:42 +00:00
X512 43def5e333 Fix source code encoding
Make it correctly readable as UTF-8 encoding.

Change-Id: Ifef77aa988b8d45c485927b698526e234711425c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2955
Reviewed-by: Adrien Destugues <[email protected]>
2020-06-27 16:58:05 +00:00
X512 9bc51ee07c BLooper: implement scripting
Change-Id: I73dd301ca7109675a4b629464ba7275a8095c77b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2940
Reviewed-by: Adrien Destugues <[email protected]>
2020-06-24 14:08:28 +00:00
X512 079e9eef15 BListView: complete scripting support
Change-Id: Iff4b5cb775d1c0b0e588459429d6df7fb93a760e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2945
Reviewed-by: Adrien Destugues <[email protected]>
2020-06-24 14:08:16 +00:00
X512 8fbce87334 BMenu: implement scripting
Fixes #15540.

Change-Id: I965d04bcbb6db41cc7a744d18fa3c9ffab2a81f1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2941
Reviewed-by: Adrien Destugues <[email protected]>
2020-06-24 14:08:16 +00:00
X512 1e4192fc86 Magnify: fix scripting
Change-Id: If7f283d35c4af894c0db58ea015b4f3ea278ecdd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2939
Reviewed-by: waddlesplash <[email protected]>
2020-06-21 18:08:07 +00:00
X512 111247c842 app_server: match behavior when drawing to BPicture
Change-Id: I7676e73bda0eb02a1905888706aab6bb1db401d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2892
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2020-06-20 18:33:30 +00:00
X512 e1bb846d71 BColumnListView: fix keyboard navigation
Make expanding/collapsing logic the same as in BOutlineListView.

Change-Id: Ia8669ec6ac1be15c09879aa759474b4841451c39
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2933
Reviewed-by: John Scipione <[email protected]>
2020-06-20 18:14:48 +00:00
X512 fbb8bf7ee3 Preferences/Input: fix scripting
Change-Id: Iafe52399f193c079eac8c45273801c762a99e023
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2935
Reviewed-by: waddlesplash <[email protected]>
2020-06-20 18:12:51 +00:00
X512 2e4991285b app_server: fix transformations in BPicture
Fixes #16122, #16147.

Change-Id: Iee7aa8a2325d34a526578a58507ea3690459c8d7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2898
Reviewed-by: waddlesplash <[email protected]>
2020-06-10 04:04:24 +00:00
X512 b8e5671d53 app_server: fix transformations in BPicture
Fixes #16122, #16147.

Change-Id: I16a38919d25836546389aff6093415eda781668f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2889
Reviewed-by: Stephan Aßmus <[email protected]>
2020-06-10 01:12:04 +00:00
X512 8301c4980b AutoDeleter: add operator [] for ArrayDeleter
Change-Id: I015951053050b58e73fd71e4abb104a0755416f7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2890
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>
2020-06-09 08:10:42 +00:00
X512 638f8647a6 app_server: fix crash caused by missing locking
Change-Id: Ib9b0c2282f947c0c6ac61fc3e97f9eca7af8dda4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2891
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>
2020-06-09 08:05:47 +00:00
X512 69c8afc98e ServerPicture: add missing header
Fixes build.

Change-Id: I4b38483f77fdce9f183db5b1f63c3b138ab5c748
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2895
Reviewed-by: waddlesplash <[email protected]>
2020-06-09 01:34:20 +00:00
X512 1d22b1ae63 PicturePlayer: use BStackOrHeapArray
Change-Id: I7908d8304276d14782bde5c2b8c089f3ca0138e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2894
Reviewed-by: waddlesplash <[email protected]>
2020-06-08 14:19:18 +00:00
X512 9692db62e7 app_server: use BStackOrHeapArray
Change-Id: Ieb335d51923bf28b0e4f830535f74dede42933a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2893
Reviewed-by: waddlesplash <[email protected]>
2020-06-08 14:19:18 +00:00
X512 c47cb94a5e BOutlineListView: fix keyboard navigation
* On left arrow key select parent item when selected item is collapsed.
* Scroll to selected item when expanding/collapsing.

Change-Id: Ia404abb970376d4168efd8bba4d8817712a885a6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2873
Reviewed-by: waddlesplash <[email protected]>
2020-06-03 14:00:17 +00:00
X512 ca3e2eaaea app_server: don't use BLaunchRoster for libbe_test
It cause starting launch_daemon for every test_app_server run.

Change-Id: I061ee1e1a7bb18f0e471a03885fbf1168393ba5b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2831
Reviewed-by: waddlesplash <[email protected]>
2020-05-28 14:24:03 +00:00
X512 4b5b437427 ViewHWInterface: make updating faster, capture pointer on mouse down
Change-Id: I14551e9db2ddb47e8aab492c2d241df1001f6d79
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2830
Reviewed-by: waddlesplash <[email protected]>
2020-05-28 14:23:26 +00:00
X512 ec43e4f4c2 AutoDeleter: do not allow copy
Change-Id: Ieab0fea46fc23c446bbaca407e3e80a4a7901896
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2704
Reviewed-by: waddlesplash <[email protected]>
2020-05-16 18:23:09 +00:00
X512 451cf86feb Tracker: fix debug build
Change-Id: I8a31802366b3dcbadc9ce1ba903161fa3fcad60d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2679
Reviewed-by: waddlesplash <[email protected]>
2020-05-13 02:05:29 +00:00
X512 83bd4fdac3 app_server: fix stack overflow crash if too many windows are tiled
Fixes #15796.

Change-Id: I24c29215116e6bad37f0a56e141d6fc26bbe4fb2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2680
Reviewed-by: Adrien Destugues <[email protected]>
2020-05-11 17:10:18 +00:00
X512 db3a94141a SeparatorItem: support horizontal layout
This is required for BMenuBar based toolbars.

Fixes #15785.

Change-Id: I8d108694b481e408e5c56e23a697c8e7829343dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2316
Reviewed-by: Adrien Destugues <[email protected]>
2020-05-10 15:45:27 +00:00
X512 b7c0f682e4 BListView: fix ScrollToSelection
When selection moves down, BListView was sometimes scroll to upper item,
not lower.

Change-Id: I8f3cf87d43e93c3d2cabfd7ca76f44f1575525e0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2311
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2020-05-03 19:38:57 +00:00
X512 8ff2f81f6b test_app_server: add RemoteHWInterface
Change-Id: I67473c9df4a81aab42d2bb92f93078abc3d7b6d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2512
Reviewed-by: waddlesplash <[email protected]>
2020-04-28 00:45:19 +00:00
X512 f569b97029 test_app_server: add multiple screen support
Change-Id: I89fb30936160615d28aebb36c8b1f84690007de7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2511
Reviewed-by: Adrien Destugues <[email protected]>
2020-04-28 00:45:19 +00:00
X512 bd3b700484 screenmode: fix MIME signature
Change-Id: Id7f1ffea799b4843076abe4e791d949dcb2f0339
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2518
Reviewed-by: waddlesplash <[email protected]>
2020-04-26 17:37:18 +00:00
X512 eeff891b9d Message screensaver: style fixes
Change-Id: Ifd910a517411e888eaee0efda2fa18838a1023d7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2513
Reviewed-by: waddlesplash <[email protected]>
2020-04-24 23:51:12 +00:00
X512 3ed66cafba Message screensaver: fix array delete[] problem on clang, style fixes
Change-Id: Ic0182e81e9267c69b92ed60a85026eb45cda3a2d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2407
Reviewed-by: waddlesplash <[email protected]>
2020-04-24 22:34:07 +00:00
X512 6d31c23459 test_app_server: fix build
Change-Id: I5fa78adf04bf4380e340d470eb98377e574d3801
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2510
Reviewed-by: waddlesplash <[email protected]>
2020-04-24 22:30:15 +00:00
X512 04ff1cfaef i2c bus_raw: fix passing cmdBuffer, handle large buffer size
Change-Id: Ia2965d465899d087f0cbf8f7b07a7a326ed305db
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2496
Reviewed-by: Jérôme Duval <[email protected]>
2020-04-20 14:56:16 +00:00
X512 b29db8ebbb AutoDeleter: add Get method for FileDescriptorCloser
This allows to use FileDescriptorCloser as unique pointer for file descriptor.

Change-Id: I4c768fafba6ed35658b2fdb075b9b547f53bc8da
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2495
Reviewed-by: Jérôme Duval <[email protected]>
2020-04-20 14:56:16 +00:00
X512 9219768a97 scsi: add device names
Change-Id: Ifca8911a095ee93daf1b4976a037dbd7c016e923
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2494
Reviewed-by: Jérôme Duval <[email protected]>
2020-04-20 14:56:16 +00:00
X512 898afd0a20 i2c: add device names
Change-Id: I1cb40223cdb43cc7069aee382657aac2b4cfd62b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2481
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2020-04-16 11:52:47 +00:00
X512 e3b7218370 pch_i2c: implement acpi_scan_bus
Change-Id: Ib2297246ea53c9e65d602961b615c2e1f4b3478a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2480
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2020-04-16 11:52:47 +00:00
X512 47102c0742 Interface Kit: introduce B_TRANSPARENT_BACKGROUND flag
BeOS didn't support transparent views. As documented in the Be Book,
SetViewColor(B_TRANSPARENT_COLOR) only effect is to not fill the
invalidated areas with the view color before calling Draw() (it avoids
flickering, especially when combined with B_FULL_UPDATE_ON_RESIZE).

A previous change made B_TRANSPARENT_COLOR actually make the view
transparent (that is, additionally to the above, the underlying view is
drawn before the transparent children), but it creates compatibility
issues.

In order to keep the API compatible with BeOS, the new behavior is now
enabled explicitly using the B_TRANSPARENT_VIEW flag. This also opens
for future developments like allowing a view color with an alpha
channel (not supported yet).

Adjust programs that require transparent views.

Fixes #15744, #15745.
Helps with #15645.

Change-Id: I529574ea23db0a23579521b263bc8d572775e35a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2275
Reviewed-by: Adrien Destugues <[email protected]>
2020-04-16 00:59:37 +00:00
X512 23177782fd RAWTranslator: fix integer overflow
Pointed by clang.

Change-Id: I6e2c62ccfa7bec381a02b08d54c7469bbb8d7a67
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2406
Reviewed-by: Adrien Destugues <[email protected]>
2020-04-16 00:58:41 +00:00
X512 67597f4204 Interface kit: fix regression introduced in hrev53944
In hrev53944 selection is cleared if text view lose focus, but it
don't work properly in StyledEdit, causing clearing selection when
menu is opened. Clear selection on lose focus is needed for text controls,
so when you click on another text control, previosly focused text
control should clear selection. This behavior is working in BeOS, so
some investigation is required.

Fixes #15810.

Change-Id: Ie104fc1d7e76c2cd2b97d3a0462856fe70cccbbf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2355
Reviewed-by: Stefano Ceccherini <[email protected]>
2020-04-11 16:55:53 +00:00
X512 f4fce2fd2e HttpRequest: use off_t for reply content size
Fixes #15850.

Change-Id: Ic5d64ecba92306cbe798c94ac8e4a7626125e09b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2464
Reviewed-by: Adrien Destugues <[email protected]>
2020-04-08 14:16:46 +00:00
X512 663c9749e1 Pulse: fix type for format string
Pointed by clang.

Change-Id: I3809c15ccc7c1f268ac3d9088896d7cd1488226d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2405
Reviewed-by: waddlesplash <[email protected]>
2020-03-28 20:04:49 +00:00
X512 bf9093e794 Efi: fix headers for 32 bit platforms
Change-Id: Id43bfcbfc24b1adb8f6e9fff587c6df9b62910f2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2413
Reviewed-by: Alex von Gluck IV <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2020-03-28 20:03:37 +00:00
X512 9d6177614b PPMTranslator: fix clang warning self-assign, remove redurant braces
Change-Id: I2b3f61fdf482c56b4520174e7a9c48f4ac64e1f2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2404
Reviewed-by: Adrien Destugues <[email protected]>
2020-03-24 03:09:55 +00:00
X512 33378c1413 Bluetooth: fix out of bounds access
Pointed by clang.

Change-Id: If8f60619bd98027ae7bc0e7ecaa1c86db6bacf0e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2403
Reviewed-by: Adrien Destugues <[email protected]>
2020-03-24 03:09:55 +00:00
X512 e2c0896a2b Sudoku: 64 bit fix
Pointed by clang.

Change-Id: I996454dcee8484716946d08d3318daf8d815b7cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2402
Reviewed-by: Jérôme Duval <[email protected]>
2020-03-23 10:20:38 +00:00
X512 fc179324b0 radeon: fix computing difference
Also fix clang warning self-assign.

Pointed by clang.

Change-Id: I0e104420414fecece87015a0af9a4535ccfc8263
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2401
Reviewed-by: waddlesplash <[email protected]>
2020-03-23 01:30:23 +00:00
X512 39be4f89f5 Fix clang warning string-plus-int
Clang message: error: adding 'size_t' (aka 'unsigned long') to a string
does not append to the string

Change-Id: Ice854f584e92917aca6821d5ec2352fc4e38f2f0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2395
Reviewed-by: waddlesplash <[email protected]>
2020-03-23 01:30:23 +00:00
X512 f17d2fbb4e app_server: fix clang warning tautological-constant-out-of-range-compare
Clang message: error: result of comparison of constant -1 with expression
of type 'direct_driver_state' is always true

Change-Id: I0ae352985a143f1d97b02ca01550480613db6c3e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2394
Reviewed-by: waddlesplash <[email protected]>
2020-03-23 01:30:23 +00:00
X512 668ecf4f09 Kernel: fix operator priority warning
Pointed by clang.

Change-Id: I16aa242c94abdf1fa22c4651e63c8c236e6c1a82
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2393
Reviewed-by: John Scipione <[email protected]>
2020-03-23 01:30:23 +00:00
X512 f7db27344f Keymap: remove iterator change inside for loop, no functional change
Pointed by clang.

Change-Id: I3aaad5b1e03385358ccb729251fa31d35108f389
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2392
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Alex von Gluck IV <[email protected]>
2020-03-23 01:30:23 +00:00
X512 1e3d4cf78c Kernel: remove dead code
area->name is a fixed array inside struct, not pointer, so it should
be never be NULL.

Pointed by clang.

Change-Id: Ic8930450cb8461eef158bc854f214eb47d92ce22
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2391
Reviewed-by: Jérôme Duval <[email protected]>
2020-03-23 01:30:23 +00:00
X512 8152128002 Fix clang warning "mismatched-tags"
Change-Id: I00f26e27d8ac24a46b528ea7ed47b92c2967ff2e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2390
Reviewed-by: waddlesplash <[email protected]>
2020-03-23 01:30:23 +00:00
X512 77f5125586 Fix double extern "C" pointed by clang.
Change-Id: Ie595dd99d01149868a4f60354ef89fa861cf856b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2389
Reviewed-by: waddlesplash <[email protected]>
2020-03-23 01:30:23 +00:00
X512 910651da23 Deskbar: add middle click shortcut
* Middle click on team item launch new instance of team.
* Shift+middle click on window item closes window.

Change-Id: Iaf201b8fe87dcc4430afd451a7ad3654178389a0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2337
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Sergei Reznikov <[email protected]>
2020-03-11 10:32:04 +00:00
X512 1c9c772967 Interface Kit: make BTextControl behave like BeOS
Contents of BTextControl should be not selected if text is directly clicked.
Selection should be removed if BTextView lose focus.

Change-Id: Ifba914c2ada4fc1aac88205f69a64a4356009469
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2109
Reviewed-by: waddlesplash <[email protected]>
2020-03-07 18:48:32 +00:00
X512 5d17f05f5f BFS: allow deleting "bad data" files
"bad data" files now can be deleted with "rm --force <name>".

Fixes #15730.

Change-Id: I44bda91f3c2198d30212b4d7791a9b55f947c926
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2257
Reviewed-by: Axel Dörfler <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2020-03-07 18:15:10 +00:00
X512 9b33a309da Interface Kit: fix menu resizing when scrolling is enabled
BMenuWindow::Attach/DetachScrollers can be called when scrollers are
already attached/detached and it should handle this case properly.

Call BMenuWindow::DetachScrollers when scrolling is not needed anymore.

Fixes #8513.

Change-Id: I1f70b63d75106cf33ab1f72d34e221a54b45a75e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2310
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: John Scipione <[email protected]>
2020-03-07 17:33:25 +00:00
X512 fa60e7a684 BMenu: remove delay when opening submenu with mouse
Fixes #11703.

Change-Id: Iae01eeffee27ecde5bb333c85b8c3cb411f1bd00
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2274
Reviewed-by: Sergei Reznikov <[email protected]>
Reviewed-by: humdinger <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2020-02-27 00:51:48 +00:00
X512 48de299d54 FontDemo: remove flickering workarounds
Part of #15623.

Change-Id: Iddd1bff519fac8f5387ba1eeec22cc2314112271
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2276
Reviewed-by: waddlesplash <[email protected]>
2020-02-25 04:49:58 +00:00
X512 371b3b2b42 Keymap: remove flickering workarounds, small fixes
Part of #15623.

Change-Id: I44d62a39efeaa25ecdc3b8a9aa27ca9fef33e5b9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2279
Reviewed-by: waddlesplash <[email protected]>
2020-02-25 04:44:29 +00:00
X512 f9b0390d8f PowerStatus: use transparent view
Change-Id: I04d988a54d0199e8c7dac37f5b78c6f1e2e0cadc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2278
Reviewed-by: waddlesplash <[email protected]>
2020-02-25 04:42:23 +00:00
X512 485a9ea0e6 NetworkStatus: use transparent view
Change-Id: I707f043e08b7f54de1304c7697e19621ff279c7c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2277
Reviewed-by: waddlesplash <[email protected]>
2020-02-25 04:42:23 +00:00
X512 17a91a9886 BMenu: fix menu navigation area
Change-Id: If9326ebc99978627d9dfb1eaff67912f0114f292
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2071
Reviewed-by: waddlesplash <[email protected]>
2020-02-25 04:41:22 +00:00
X512 e18a08119d GLTeapot: normalize quaternion
Quaternions representing rotation should have unit length. Multiplying
quaternions cause error accumulation and length change. Normalizing
quaternion after rotation will avoid that.

Fixes #7160.

Change-Id: I82f1f2b89c326a4d2c956c03296600e79ac267c2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2270
Reviewed-by: Jérôme Duval <[email protected]>
2020-02-24 15:15:12 +00:00
X512 9176b546e3 Haiku3d: fix textures
Textures creation like other OpenGL calls must be inside LockGL/UnlockGL.

Fixes #15246.

Change-Id: Id1f3ae7c04548dba301e5c5ba75a89163c08d69d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2269
Reviewed-by: Adrien Destugues <[email protected]>
2020-02-23 07:53:19 +00:00
X512 6bff918400 Tracker: fix window focus behaviour
* Also fix LongAndDragTrackingFilter
Fixes #15605

Change-Id: I98c5f3ca435e54c98515ebe2fccbbfd5d08c1a25
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2081
Reviewed-by: Sergei Reznikov <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2020-02-17 17:29:13 +00:00
X512 b3de8bea44 Package Kit: convert HTTP error code only on BHttpRequest
Other request types exists such as BFileRequest.

Fixes #15675.

Change-Id: Ib2e07fad4dd9f682d2b9fc0cdbf0ca60ecd3adfb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2200
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: François Revol <[email protected]>
2020-02-05 14:55:45 +00:00
X512 c529e2a354 debug heap: implement malloc_usable_size
Change-Id: I49d7918df00cca4b889f6a3cf52c3f903ee5fa2a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2179
Reviewed-by: waddlesplash <[email protected]>
2020-02-02 23:38:37 +00:00
X512 958d3f4375 BeBuild: set default visibility for _EXPORT
This is required for building shared libraries with hidden by default symbol
visiblility such as mesa.

Change-Id: I7150629aaea61d7c9b6e641d32913c5cc7c96543
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2159
Reviewed-by: Adrien Destugues <[email protected]>
2020-01-30 00:32:32 +00:00
X512 7512485b94 Optimize system_time function
The uint128 code does not optimize as well as expected. Since this
function can be called quite often, use a more optimal implementation
(quite similar to what we had for x86_64 before refactoring).

Unfortunately this is still not as good as the hand-optimized assembler
previously used for 32bit x86, unless compiled with clang, where it gets
pretty close.
2020-01-26 14:48:30 +01:00
X512 7740e52c16 TextSearch: fix passing search string to grep
Fix proposed by phoudoin.

Fixes #15650.

Change-Id: Ie7177aaa39ff593445506983cb0725b75ca7bc7d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2149
Reviewed-by: Jérôme Duval <[email protected]>
2020-01-24 15:23:01 +00:00
X512 cc0226fad0 ActivityMonitor: remove double buffering and custom background drawing
Part of #15623.

Change-Id: Id6b7c13623e66d5b88ffc48766a5fe5ec4099b64
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2133
Reviewed-by: Stephan Aßmus <[email protected]>
2020-01-19 18:27:55 +00:00
X512 59b700d086 Interface Kit: remove more workarounds for BDragger
This workarounds are no longer needed after hrev53713.

Change-Id: I7b809c79bd9d2345a991f0d2360f79876d10cd6b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2132
Reviewed-by: Stephan Aßmus <[email protected]>
2020-01-19 18:25:22 +00:00
X512 c4a686d8d1 Interface kit: fix displaying draggers when they were initially hidden
IsHidden(this) should be used instead of IsHidden() because IsHidden() return
true if window is hidden (at moment of creation for example).

Fixes #15646.

Change-Id: I08c8bacd634139dd62fb239e16cb80f512e4be6d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2128
Reviewed-by: Stephan Aßmus <[email protected]>
2020-01-19 18:22:41 +00:00
X512 52ac76ce34 Interface Kit: fix BDragger background drawing
Change-Id: I1ce8eca127e14af0652ef38fedcbbf588f1567fd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2092
Reviewed-by: Adrien Destugues <[email protected]>
2020-01-16 13:23:57 +00:00
X512 6ab29b9387 app_server: fix drawing of transparent views
This change makes to draw parent view before current view if current view
ViewColor is transparent. Views with transparent parts such as BDragger are now
drawing properly without workarounds.

Change-Id: I0450d1f012555137c8e7dd2d08c0c27df39465ff
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2091
Reviewed-by: Stephan Aßmus <[email protected]>
2020-01-12 16:10:29 +00:00
X512 3d7fbc1a0b runtime_loader: allow loading executables without section table
Change-Id: I4bfee1d1aa40730586123a70fb480ee91787c15d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2089
Reviewed-by: Jérôme Duval <[email protected]>
2020-01-12 13:59:40 +00:00
X512 cf4ffd85fd app_server: fix flickering when drawing background
Fixes #15548.

This change disables immediate drawing of background on expose and makes drawing background a part of the update session. In previous version expose/update separation is incorrect in some cases. For example when view with B_FULL_UPDATE_ON_RESIZE is resized, it will be updated with expose cause, that will trigger flickering. Correct handling should be update on old visible area and expose on area that became visible. If immidiate exposed area erasing is preferred, it need more work to fix. Anyway delayed redrawing cause problems only on slow machine or on slow responding applications, but current master approach cause flickering even on fast machines and on any application that use non-transparent view color.

Multiple expose/update requests also seems not work properly.

Change-Id: Ibd64eb2545ceb1197f1c8bc89043de6f87f11778
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2021
Reviewed-by: Stephan Aßmus <[email protected]>
2020-01-12 12:10:05 +00:00
X512 db7c4791bb Interface Kit: read reply before calling hooks.
Part of #15548.

Change-Id: I074d36717ef1e2fad4e8bc215448fa72f797ed7f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2099
Reviewed-by: waddlesplash <[email protected]>
2020-01-11 18:54:36 +00:00
X512 f6779f3d47 WebPositive: call base class in BookmarkBar::FrameResized
Fixes #13067.

Change-Id: Ia40ef83ea3e9676c9884e011b758b85d6bd27fcd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2102
Reviewed-by: waddlesplash <[email protected]>
2020-01-11 18:32:39 +00:00
X512 2cf8f0ee6b kernel: add assert in _user_read_dir
* This will help catch bugs such as in #15607.

Change-Id: I25b28932f9db4e2abe8499dd829c910bb565086b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2082
Reviewed-by: waddlesplash <[email protected]>
2020-01-10 00:24:56 +00:00
X512 3e818f2075 bfs: keep valid dirent->d_reclen in case of bad name
Fixes #15607.

Change-Id: I96b807f031df4e5c8b5ae17b22a21aed77616b17
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2083
Reviewed-by: Axel Dörfler <[email protected]>
2020-01-08 20:05:58 +00:00
X512 801a1fe1a9 debug_server: make crash dialog button default
Change-Id: If05f775fe919445b3e18d356a9837fdb6fabf5cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2063
Reviewed-by: Adrien Destugues <[email protected]>
2020-01-02 13:38:08 +00:00
X512 1a221bf3d3 haiku3d: fix crash on exit
Change-Id: I0d3d5d333f1dad5818149cde0fed29797f12e825
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2062
Reviewed-by: Axel Dörfler <[email protected]>
2019-12-31 17:42:31 +00:00
X512 9ca1f3a903 app_server: don't focus the window on mouse down if it accepts first click
* matches BeOS behaviour. Fixes #15544.

Change-Id: I2a3636024753b53ba9ad6446c187e6a4479c31b6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2020
Reviewed-by: John Scipione <[email protected]>
2019-12-31 09:28:59 +00:00
X512 bb501d4c74 BTextView and BListView: fix scripting
fix #15539

Change-Id: I5139b91214e19b35af1ead203c070837b7a15bd9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2017
Reviewed-by: Jérôme Duval <[email protected]>
2019-12-16 09:51:16 +00:00