Instead of forcing a click to open rect this just restarts menu tracking if the
mouse was clicked. It seems to work great and is cleaner than my solution which
is removed in this commit as well.
This still fixes the problem of accidentially selecting menu items but also
maintains the API.
Good job Pete!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40306 a95241bf-73f2-0310-859d-f6bbb57e9c96
This fixes#7022 and is mostly based on the patch attached to that ticket, with
these changes:
- The patch was adding this to the private _TextInput_ class, not BTextView.
- The patch had a Clear menu item too. I removed that due to the different
semantics between Clear in a BTextView and in a TextInput. The former just
clears the selection where the latter clears the whole view.
We could later add a virtual callback for adding menu items to this context
menu which could be used to add Clear with the two semantics in each class
(this is mainly needed for the enabling logic...each class could handle a clear
message in its own way.) This callback could also obviously be used for other
things, like a spell-check menu or whatever an application would want to add.
Since BTextView has 10 free virtual slots it seems reasonable to add.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40305 a95241bf-73f2-0310-859d-f6bbb57e9c96
when the Tracker window is closed. Tested with normal navigation and
slideshows.
Axel's excellent navigation classes code made this pretty easy.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40180 a95241bf-73f2-0310-859d-f6bbb57e9c96
by forcing openAnyway and creating a clickToOpen rect if there is not one.
Should fix#7022 and maybe others. Partially based on the patch from #7022 and
Travis Reed's patch from the mailing list discussion in December.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40142 a95241bf-73f2-0310-859d-f6bbb57e9c96
Similar changes should be made in other applications. I may try doing so
with a script (and manual review of course.)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40136 a95241bf-73f2-0310-859d-f6bbb57e9c96
If the menu opens right under the mouse cursor, do not select or invoke an item
until the mouse is moved. Since this seems to break normal menu bars, I added
the check for fSuper. As a (bad?) side effect BMenuField menus also need mouse
movement before something is selected. If anything else is broken, let me know.
I'm committing this because it does remove some bad behavior in pop up menus
(unintentionally selecting items.)
We may also want to force the openAnyway behavior as discussed on the mailing
list in December.
In general though the menu handling code really should be redesigned/refactored.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40132 a95241bf-73f2-0310-859d-f6bbb57e9c96
specifier to float constants. Hopefully I'm done with this now.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40110 a95241bf-73f2-0310-859d-f6bbb57e9c96
Also moved private methods to the bottom of source files.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40108 a95241bf-73f2-0310-859d-f6bbb57e9c96
differently in Germany, but NetworkTime was always setting my time 6 hours
ahead, no matter what time zone or whether I stored the time in local time or
GMT. Upon looking closer and doing some Googling I determined that the constant
Axel used for the number of seconds between 1900 and 2000 was off by 6 hours,
and that combined with the odd kUTCtoGMT constant resulted in the 6 hour
difference.
By just replacing the system_time_difference() function with a correct constant
for the number of seconds between 1900 and 1970 and getting rid of kUTCtoGMT it
now works for me (and at least one other person on #haiku-dev, thanks
kallisti5!) For those wondering NTP time is measured from 1900 hence the need
for this conversion.
I will now look into integrating this with the Time preflet.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40103 a95241bf-73f2-0310-859d-f6bbb57e9c96
Pretty much implements everything needed to set a swap volume once that is
implemented on the kernel side. This also improves the behavior of the Default
button.
A few changes I made:
- When the swap volume feature is turned on in the code, default to the boot
volume if the settings file does not have one set.
- Don't show the volumes menu field in the GUI if the swap volume feature is
not on.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40101 a95241bf-73f2-0310-859d-f6bbb57e9c96
Butterfly by Geoffry Song.
Leaves by Deyan Genovski and Geoffry Song.
Thanks guys!
I fixed a few coding violations and wrote the Jamfiles.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40098 a95241bf-73f2-0310-859d-f6bbb57e9c96
based on Hamish Morrison's work on a GCI task. The changes I made from his
patch were to move this from preferences to apps (I think it is more of an app
than a preflet) and to change the name back to NetworkTime (he had made it
NTP, but most people probably won't know what that stands for.)
This also fixes#2412.
I noticed some changes this could use but wanted to add it before making any
changes so there is an SVN history of those changes. I'll probably also make an
icon in the next few days.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40088 a95241bf-73f2-0310-859d-f6bbb57e9c96
I assume if this wasn't wanted the ticket would have been closed, and I think
this is fine.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40085 a95241bf-73f2-0310-859d-f6bbb57e9c96
default minimum instead of zero when the user turns on virtual memory. Thanks!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40056 a95241bf-73f2-0310-859d-f6bbb57e9c96
is used. In my testing this did not seem to be a problem but it doesn't hurt to
fix it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40012 a95241bf-73f2-0310-859d-f6bbb57e9c96
B_TRANSLATE("???") returns something larger than the size of name.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40011 a95241bf-73f2-0310-859d-f6bbb57e9c96
probably not needed.)
Another problem fixed here is that the border width value is in "border width"
not "border" so this code wasn't really working before.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40007 a95241bf-73f2-0310-859d-f6bbb57e9c96
problem without a bunch of refactoring. I intend to do more refactoring of
ShowImage after developing an automated test suite.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36800 a95241bf-73f2-0310-859d-f6bbb57e9c96
by 5 pixels. Add a check so that multiple context menus aren't opened.
Also don't draw a 0 x 0 selection rect.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36799 a95241bf-73f2-0310-859d-f6bbb57e9c96
one page.
Also a small refactor of a variable name in that area.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36798 a95241bf-73f2-0310-859d-f6bbb57e9c96
about on the mailing list.
Stephan if you want to adjust the colors of the Touchpad or whatever else, feel
free.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36611 a95241bf-73f2-0310-859d-f6bbb57e9c96
There are a few small changes from myself, such as adding a copyright for
Maxime in files with bigger changes. Also because this patch was so old I had
to do some manual patching, and added back the title and description on the TGA
and TIFF translators.
I think this improves things a lot, though there is still some work to do to
improve the consistency of the translator settings views.
I think this mostly fixes#2117, though I may leave the ticket open until a few
more things are resolved.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35769 a95241bf-73f2-0310-859d-f6bbb57e9c96
ALM Layout so that it is font sensitive and that translator config
views can also use the Layout API.
Fixes#3789.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35768 a95241bf-73f2-0310-859d-f6bbb57e9c96
* Add constants for the length of the resize area on a window border and for
the size of the resize knob on document windows.
* Clarify some comments.
* Change instances of thumb to knob in reference to the resize knob. It was
called knob in some places and thumb in others.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35706 a95241bf-73f2-0310-859d-f6bbb57e9c96
This fixes#4628.
I added the TODO because I think this code is getting hairy.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33431 a95241bf-73f2-0310-859d-f6bbb57e9c96
improvements:
* fixed text for "Use Text" radio button in Find dialog being cut off
* more user friendly error messages for Find dialog:
"no search string" becomes "No search string was entered.", or "Nothing is
selected." as appropriate.
* Preferences dialog opens unacceptably slow when a larger number of fonts are
installed due to AppearPrefView's "IsFontUsuable" routine. But was able to
cut opening time by about half with a minor optimization to the loop.
* Fixed an ugly word-wrap of Takashi Murai's name in About dialog
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33428 a95241bf-73f2-0310-859d-f6bbb57e9c96
- The text was not centered because it was not taking into account the left
offset of the text rendering, which can be gotten from the left value of the
rect returned by GetBoundingBoxesForStrings. I'm pretty sure this was 0 on
BeOS, so there might be problems with our GetBoundingBoxesForStrings. It
doesn't make sense for flat edged glyphs like D and N to be offset. But
nonetheless taking into account that left offset centers the text in this
screensaver. This fixes#4261.
- The text rendering also could look weird because the low color was not set to
blue. Again I'm pretty sure this was not a problem on BeOS, but could be
related to the new subpixel AA rendering. Setting the low color fixes this
and therefore fixes#4252.
- To avoid any weird repaint issues in the ScreenSaver preferences preview
view, the whole background is painted every frame now.
- I also added an escapement_delta member which is used for both the
GetBoundingBoxesForStrings call and the eventual text rendering. This may be
pointless, but it is probably more consistent.
Other changes:
- This now makes use of the new settings view private function.
- I made the coding style compliant with our latest guidelines (I think I got
most of the big ones at least.)
- Removed the references to the old BeOS screen saver kit stuff from the
Jamfile.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33404 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Make the BuildScreenSaverDefaultSettingsView function be built into
libscreensaver.so and under the BPrivate namespace. This avoids the repetition
of the compiled code in each screen saver that uses it.
- Updated the ScreenSaver preferences to use this.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33403 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Added use of the new BuildScreenSaverDefaultSettingsView function (this is
basically the same code.)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33402 a95241bf-73f2-0310-859d-f6bbb57e9c96
default look for the settings of screen savers without complicated settings
views. This is based on the code originally in the ScreenSaver preferences
window.
Also fixed a type in the ScreenSaverRunner header.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33400 a95241bf-73f2-0310-859d-f6bbb57e9c96
the previous version (which at least broke BeZilla.) This is part of #4363.
+alphabranch
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32983 a95241bf-73f2-0310-859d-f6bbb57e9c96
space bars being on. Thanks for the tips Axel.
+alphabranch
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32934 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Removed bitmap icons.
- Updated rdef copyrights.
- Added them to the image.
I also tested them.
+alphabranch
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32799 a95241bf-73f2-0310-859d-f6bbb57e9c96
settings ("Show x"). This required changing various logic, some of which I
think was also wrong in the negative settings case. Now if you turn off the
border when the title is on, the title will come back when the border is turned
back on. But any changes in the title setting force the border back on. When
loading the settings the border setting takes precedence.
+alphabranch
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32656 a95241bf-73f2-0310-859d-f6bbb57e9c96
instead just check if the size limits need to be set. The code that previously
did this when processing the B_LAYOUT_WINDOW message was extracted into a
private method, which is called from both places.
This may be slightly wasteful in some cases (since the size limits may be set
multiple times), but it is definitely needed because without it both of the
current test apps (DiskProbe and Screenshot) did not have properly centered
windows.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32622 a95241bf-73f2-0310-859d-f6bbb57e9c96
methods as well as Size(). To avoid the problem of centering the window before
it has been resized by the layout system, I force the resizing early. If there
is a better way to do this or some way to avoid doing it repeatedly, let me
know. But I figure the Center* methods should not be called that often.
Updated Screenshot and DiskProbe to use this new method as a test. It certainly
cleaned up DiskProbe. I will update other code over the next few days (if
anyone wants to help, please do :)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32612 a95241bf-73f2-0310-859d-f6bbb57e9c96
image and DevelopmentMin optional package. This is the original libjpeg (6b),
which I will updated to version 7 within the next few days. I need to
understand better the modifications made to it before updating.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32553 a95241bf-73f2-0310-859d-f6bbb57e9c96
directory. I think this should be good enough until we have session management.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32545 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Move the launching of files in this directory from the Bootscript to the
UserBootscript.
- This means we now ship a working UserBootscript instead of just a sample.
- Updated documentation based on this change and Humdinger's suggestions.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32544 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Remove '`' and '~' keyboard shortcuts from DoKey as those will no longer be
processed there (they are processed at a higher level.)
- Make shortcut for previous app '1' (same behavior as the left cursor key.)
This required adding B_UNMAPPED_KEY_DOWN to MessageReceived since it is actually
Ctrl-1 that is being pressed (which is unmapped in our default keymap.)
- Make the processing of Ctrl-~ (or `) cycle through the windows when the
Twitcher window is showing. This is to mimic the behavior when the Twitcher
window is never shown. There is still a bug though: the order of the switching
changes after the Twitcher window is shown. Why do we have both CycleWindow and
SwitchWindow methods in TSwitchManager? The changing of order seems to be due
to the use of SwitchWindow instead of CycleWindow. I suppose this is for the
day when we implement quick window switching?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32533 a95241bf-73f2-0310-859d-f6bbb57e9c96
there is a better place please move it there. Also fixed a bad link in the
Tracker section.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32528 a95241bf-73f2-0310-859d-f6bbb57e9c96
The dead simple Bash code was just copied from Humdinger's patch on #1202. He
also suggested having a link on the Deskbar for this folder, but I don't know
if that is needed. We just need to document it, which I may do next.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32527 a95241bf-73f2-0310-859d-f6bbb57e9c96
suppose the mapping of MIME types to app signatures is case insensitive. So
I guess this is mainly cosmetic.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32506 a95241bf-73f2-0310-859d-f6bbb57e9c96
We really should come up with a way to avoid the duplication between the rdef
and source code...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32505 a95241bf-73f2-0310-859d-f6bbb57e9c96
is pressed.
- Took Humdinger's excellent advice from #4190 to open the Backgrounds
preferences from ShowImage instead of setting the background manually. This
required some tweaks to the Backgrounds preferences to accept RefsReceived in
the application and forward that to the view. In addition the placement is
set to scaled since otherwise it will keep the old placement. How this is
done is sort of hacky, but I'm going to call it an "internal protocol." This
also allowed me to remove the BackgroundImage code from ShowImage which was
just copied from Tracker (yuck.)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32424 a95241bf-73f2-0310-859d-f6bbb57e9c96
a shortcut for fullscreen, but I guess the view was processing it first. So I
just removed B_ENTER as an option for next image. Also Shift plus primary mouse
was already working for moving the image.
Also I know it was discussed at length but I still wonder if all these options
for next and previous image are overkill. Now there is no way to scroll with
the keyboard. And there isn't an easy way to go to the next image with the
mouse (menus are a pain.) So I still think some more UI tweaking is needed to
avoid constant shifting between mouse and keyboard.
Finally I also added Command-1 as a shortcut for Original Size, but it does not
work. Anyone know why?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32343 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Add underscore to private methods.
- Use class member initializer syntax.
- Make sure all class members are initialized, use same order as headers.
- Header reordering.
- A few other small things.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32342 a95241bf-73f2-0310-859d-f6bbb57e9c96
current client of this AFAIK.) They should have been const to begin with...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32297 a95241bf-73f2-0310-859d-f6bbb57e9c96
overkill.
- Updating some copyright years.
- ResizerWindow.h was not self-contained.
Some of the other files were skipped due to complexity and planned code changes.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32296 a95241bf-73f2-0310-859d-f6bbb57e9c96
and use the navigation color for the selected window (when dragging in the
workspaces view.) I hope window->IsFocus() is enough, the DefaultDecorator
seems to have more complex logic.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31895 a95241bf-73f2-0310-859d-f6bbb57e9c96
http://karistouf.free.fr/images/BCR2000_G.jpg
The notes may not fit in with other Haiku icons and could be removed. I kind of
like them though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31598 a95241bf-73f2-0310-859d-f6bbb57e9c96
great Menu prefs icon. If the extra little "islands" seem extraneous they can be
removed easily. I figured the Yen symbol was an appropriate choice for the main
island.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31552 a95241bf-73f2-0310-859d-f6bbb57e9c96
issue. Since there may be valid reasons to have part of the media player window
offscreen this code could get annoying. I still think it is pretty though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31551 a95241bf-73f2-0310-859d-f6bbb57e9c96
hopefully it makes sense. It is definitely pushing it size-wise (997 bytes.) It
is based on an item in my house (I even set it up on my desk to draw it in
IOM.) If anyone wants to tweak it, feel free.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31497 a95241bf-73f2-0310-859d-f6bbb57e9c96
seemed odd to me. The default settings made it feel too slow in coming up, and
even the fastest settings still felt awkward. So after some trial and error I
came up with a reasonable default that feels nice to me.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31407 a95241bf-73f2-0310-859d-f6bbb57e9c96
Ryan Leavengood
