Use the proper "Set" method instead of getting and modifying an existing
entry. This creates the entry if needed.
Fixes#20166
Change-Id: I6ad8bc379372a0b04b42b0f12a46e2c07d23f60a
- Less strict sizing constraints for the button so it can always occupy
the full height of the URL bar
- Use "draw after children" for the URL bar border so it is drawn above
the button and icon edges
- Remove insets that were there to attempt to make the outline visible
(I think)
- Use negative spacing to make the button border collapse into the text
control border so they look visually as a single control
Fixes#20124
Change-Id: I4be0c422c00acbc37a4197406a86a73c3193b9f5
Fetches and adds to the usb tree the HID descriptors. It is not parsed,
as fully parsing it would require HIDParser (from the kernel) or an external parser like
hidapi. I will leave it as a TODO for now.
Changes:
- Added GetHIDReportDescriptor, which is called when a usb device is a
class 3. It will then fetch the descriptor, and append it to a string
to display as an attribute
- Added FetchReportDescriptor that uses ControlTransfer() to get the
size and the data of the HID report
Change-Id: I2f739681ef81d7bddb600d556cef9cc2e34c7870
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11166
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Kacper Kasper <[email protected]>
Generates an expandable tree structure for advanced device attributes.
It follows the attributes with the name containing '/' and becomes nested
folders.
Changes:
- Modified AddAttributes in PropertyList.cpp to not just dump all the
attributes in the Basic Information or Attributes section
- Parses through nested configurations, such as USB descriptors to be
presented cleanly
Change-Id: Ib031cb1d80737b896c83a3b1690e570c8e444d74
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11103
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Kacper Kasper <[email protected]>
- Introduced cancel connection feature in bluetooth preferences
- Moved the connection handling logic into LocalDeviceImpl
- Made a watchers list to send notices to all concerned applications
Change-Id: Iba87caff68d1b9640fa8d901059daa7a624531f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11171
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* We already have a cached version, no need to recalculate it every time
* Font's height is rounded up to match TextView's LineHeight definition
Change-Id: Iba4e5b1f53d7b5b491fac9dcb8dfe17cb89b77d8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11164
Reviewed-by: Máximo Castañeda <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Shows most of the USB attributes by extracting the values in the
internal USB tree. This is meant to display the same information as
listusb -v.
Changes:
- Added FindDevicePath in DeviceUSB.cpp to map the device to their
hardware path
- Added USBTree in DeviceUSB.cpp that goes through the configurations,
interfaces, alternates and endpoints of USB devices to set new attributes
- Linked the path found in FindDevicePath to a BUSBDevice object, that
is called in USBTree to start the extraction
Change-Id: I9fd314767dc856b3cc603346d88be438699429d9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11071
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Kacper Kasper <[email protected]>
Prevents issue where initializing a drive with an Intel partition table
that previously was imaged with a CDROM compatible image then refuses to
detect the new partition table.
This can happen if trying to reinitialize a drive that was imaged with a
Haiku anyboot image as it will then only detect as a iso9660 filesystem
and prevent further reinitialization in DriveSetup.
The initialization code for Intel and GPT partition tables will now
check for and remove an iso9660 header if present. The detection
priority for an empty Intel partition table has also been adjusted in
case a device still has the iso9660 header present.
Change-Id: I8a467e67a488be00fd99eb369203c9b7b1ce7ed3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11173
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* Sentence casing, locale-aware pluralization.
* Renamed button label (and member varible ) "Inquiry" to "Scan".
It's more natural and consistend with the status labeling.
* Removed most of the instructional text at the top of the window.
The workflow (scan->wait->add new device) is pretty self-explaining,
leaving the hint to check that Bluetooth of the remote device is on.
* Fixed padding of the layout.
* Using BStatusBar's Reset() removes the label, unless you set it again
as first parameter.
* Some style fixes pointed out by our format-bot.
Change-Id: Ide2a1e2fb2ab57bc7010dbfa52dca7462ae3df90
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11193
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* The flag should be set when they are different, not equal
* Memcmp returns 0 when all count bytes are equal
Change-Id: Ie0440b6159410f811e2b57dc48308a2b2d2ee4f4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11246
Reviewed-by: waddlesplash <[email protected]>
This reverts commit 5b81e2470e. It seems to need more work on other parts of the driver.
Reason for revert: #20171, No output/input settings in Media preferences for HD Audio after update to hrev59825
Change-Id: I44495413f63b4b40e51563e03e20d0cf372e2c8a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11244
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This reverts a small portion of f5842905e3.
I added these asserts instead of the deletions to hedge against
the Team/Thread reaching this point with timers still active.
But it seems that doesn't happen, while if thread init fails
due to OOM, we have the default timers still present, which need
to be deleted.
Fixes#20154 and #20148.
* Retrieve info from the stored configuration in GetScreenMode &
GetScreenFrame if needed.
* Use the stored configurations in _SetCurrentWorkspaceConfiguration.
The last part seems to fix#20136.
Otherwise we could block forever if the data size is
larger than the buffer size. Partial writes are an
expected behavior of stream sockets, so this should
not cause any other problems.
Fixes#20163.
We were passing our own fs_vnode, not the underlying filesystem's.
I guess this was just never tested, because it would've always crashed?
Fixes#20156.
Fixes regression introduced in c216360337
where the framebuffer info passed to the kernel came from
whatever video mode was highest numbered, rather than what
was actually selected.
Should fix#20161
Change-Id: I06c800bd8e941ed7f6b20998c1ff66cd6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11197
Reviewed-by: waddlesplash <[email protected]>
Vector icons by ZuMi, thanks!
Expand the sniffing size up to 8k, as the zip file content layout can be very variable.
Now it works with all the available samples Microsoft Office 2007+ files I can put my hands on.
Change-Id: I806a66dd3d29bb47693759ef2270b482a8d7cd69
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11182
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* The GUI strings in the Devices app were inconsistent case-wise.
Going for all sentence casing. "None" and "Unknown" look better
as lower case, which is normally used elsewhere in Haiku.
* Workspaces usage:
- "movement" is a bit coprolitic IMO. Let's go with "direction"
instead.
- "autoraise" depends on the position near the screen edge of the
mouse pointer, not the window itself. The text could be even
more precise, but we should try to be brief.
- The "+|-" switch fits better to the "workspace" parameter, as it
increases the workspace number, instead of a "movement" or
"direction".
- Fixed direction "top" to "up".
Change-Id: If26d2b1e0596e911fea06609c44fccff2086ca8d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11170
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Don't unlock in ContainerWindow's constructor; instead leave
the BWindow locked, as the BWindow constructor itself does.
* Call Run() at the end of TFilePanel's constructor. This way,
the TFilePanel will be in the state existing applications expect
it to be after the constructor runs (i.e. running and not locked),
while also performing all necessary initialization before actually
doing that, to avoid races.
* Drop TFilePanel::Show as it's not needed now.
* Revert changes to BFilePanel::Show as they're now not neede.
I retested #19499 with this change, and couldn't get it to reproduce
(while it reproduced easily with Run() called at the top of TFilePanel()
followed by the Lock/Unlock scheme.)
This should be a much simpler solution that hopefully will cause no
regressions in any of #19499, #20125, #20128, #20131, #20144.
PulkoMandy