Reverts part of 05fd080554.
I got confused by the "Details" part of the variable, mistook it
for being related to the "Show details" checkbox…
Change-Id: I0eb2a72f83a55cb306a33384da1c5c2cdde32082
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11269
Reviewed-by: waddlesplash <[email protected]>
Having sounds bundled in the Haiku image allows for a quick test
if audio playback is working and lets the user play with the
Sounds preferences.
The sounds package only contains the audio files of the theme
"Burg's Sparkly Tones" by Garrett Kabler that won the Community
System Sounds Contest of 2020 [1].
The files appear in a folder in /system/data/sounds/ .
[1] https://www.haiku-os.org/news/2020-09-11-system-sound-contest/
Change-Id: Iaeb05894c5c9c3f6433fca3ae569e1f2d56fd96d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8757
Reviewed-by: Máximo Castañeda <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
This unclutters the main window by moving the "Settings…" button to
the left and the "Show more details" checkbox into the settings
window.
Added standard shortcut ALT+, to open the settings window.
Addresses #20066.
Change-Id: I9b954b763fc84a83c9f31b3c7175ebd34969a261
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11251
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
* Sentence casing, locale-aware pluralization.
* Renamed button label (and member varible ) "Inquiry" to "Scan".
It's more natural and consistend with the status labeling.
* Removed most of the instructional text at the top of the window.
The workflow (scan->wait->add new device) is pretty self-explaining,
leaving the hint to check that Bluetooth of the remote device is on.
* Fixed padding of the layout.
* Using BStatusBar's Reset() removes the label, unless you set it again
as first parameter.
* Some style fixes pointed out by our format-bot.
Change-Id: Ide2a1e2fb2ab57bc7010dbfa52dca7462ae3df90
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11193
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* The GUI strings in the Devices app were inconsistent case-wise.
Going for all sentence casing. "None" and "Unknown" look better
as lower case, which is normally used elsewhere in Haiku.
* Workspaces usage:
- "movement" is a bit coprolitic IMO. Let's go with "direction"
instead.
- "autoraise" depends on the position near the screen edge of the
mouse pointer, not the window itself. The text could be even
more precise, but we should try to be brief.
- The "+|-" switch fits better to the "workspace" parameter, as it
increases the workspace number, instead of a "movement" or
"direction".
- Fixed direction "top" to "up".
Change-Id: If26d2b1e0596e911fea06609c44fccff2086ca8d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11170
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
If you've searched for some very long string, the menu item label
in the "History" may get so long, it stretches wider than the
screen width. Happened to me accidentally…
Truncating labels at a fixed width with middle truncation.
Change-Id: I10d457044ad67563efd59960af5093d2c8717b85
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11028
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
When you have many fonts installed, the "Font" menu in the menu bar
gets very tall. If you just want to set the style (italic, bold etc…)
or the colour of the selected text, you always have to scroll to the
very top.
Putting all fonts into a "Font" top-menu leaves the the styling actions
always accessible in the renamed "Style" menu.
Also, put the "In/Decrease size" items under "Size", similar to e.g.
Tracker's "Icon view".
Fixes#20098
Change-Id: Idadcf902b1b97fe439a4958e995722e9d76f804f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10986
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
* Tweak colors to be better distinguishable in light and dark themes.
* Added more gray shades.
* Add a border around the color squares so that they're clearly
distinguishable from the background.
* Add extra border around selected color and remove the check mark.
* Tweak "Default" color label position.
Fixes#20078
Change-Id: I8cb784ef30d3b2dcb8317e25f4f68f8632954b26
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10948
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Reviewed-by: John Scipione <[email protected]>
If the user uses localized files/folders, the 'Trash' in the
move/copy/link error message should be localized as well.
The "Printers" folder is actually ~/config/settings/printers, so
the error message should use a lower case folder name as well.
Change-Id: I1f81b4a5cf391915b0e5687d6c2534048d993483
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10035
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Similar to the "Mark as" Tracker add-on, but for custom labels
stored as files in ~/config/settings/Mail/labels.
* Sets the MAIL:label file attribute.
* The pop-up menu with all available labels also has an item to
remove a currently set label from an email, and to open the
labels folder to "Manage labels…" (add, remove, rename etc.).
* Added File_Mail_label icon to distinguish from the "Mark as"
add-on icon. It's supposed to be a narrow post-it as label…
"Mark as" Tracker add-on:
* Remove custom statuses from the "Mark as" Tracker add-on. That's
what the new labels were introduced for.
Change-Id: I912a747156da3538457f622c1e2b163700c0c7eb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10539
Reviewed-by: nephele nephele <[email protected]>
"Labels" (MAIL:label) will be used instead of the currently misused
"Status" (MAIL:status) to allow categorization of emails by the
user. These labels are only used on the locally download emails;
there's no syncing with a mail server.
(See also forum thread "Introducing a new indexed attribute META:tag" at
https://discuss.haiku-os.org/t/introducing-a-new-indexed-attribute-meta-tag.)
* Remove custom statuses from "Close and…" submenu and anything else
concerning custom statuses.
* Add a "Set label" menu with a submenu to
- Remove the current mail's label, if it has one
- Add a new label
- Choose from a list of labels (first 9 items with ALT+n shortcut)
- Open the labels folder in Tracker to manage labels
(delete/rename/etc.)
* Labels are saved as separate files in ~/config/settings/Mail/labels/
* Label files are queries for all files which have that particular
label in their MAIL:label attribute. This is convenient when
managing your label, e.g. see if there are any emails with a
certain label before deleting it.
* Added "Same label" to the "Queries" menu.
* In MenusBeginning() the files in ~/config/settings/Mail/labels/ are
read and shown with their file name as menu item.
* When an email is opened, its label file is created if it doesn't
exist already. That way the Mail app can provide labels that were
not created with it, but e.g. by manually filling the attribute in
Tracker, or via a script etc.
* Related: When populating the labels menu, make sure each label query
has the correct formula. A user may have created a label by hand or
duplicated an existing formula, in which case the query formula would
be missing or wrong.
Setting a label currently isn't supported when composing an email, as
we cannot set an attribute, because an email file isn't created until
it's sent.
Change-Id: I53fb4613ec1d2d96493169e0310c11c5ba0131c2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10384
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
MAIL:thread is added to all incoming mails and when replying to a mail.
This change adds it also to new mails that are sent.
It also sets the subject and thread to "No Subject" when empty.
Change-Id: I377b50022b203bff960b7f78ef5ff55d39a6e08e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10264
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* To avoid "micro-padding" around the scrollview, use a negative
inset to have the scrollview join borders with the window.
* Make it a regular B_DOCUMENT_WINDOW to have a full-sized resizing
corner.
Fixes#19915
Change-Id: I879eca719f91f2ae67236ecfb4cb8be1b280f2fc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10267
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>
The application name should never appear in a translatable string.
Otherwise it will always show translated in the app, even if the
user configured the Locale prefs to not "Translate app and folder
names".
Always concatenate the B_TRANSLATE_SYSTEM_NAME'ed string.
Use a regular BAboutWindow in the Sounds prefs.
Change-Id: I85f02a3aa6c76b22266d495cf7514cc499bc31e8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10234
Reviewed-by: Adrien Destugues <[email protected]>
With this change, when you hold SHIFT when going to the next email
message - either by clicking the tool bar icon or pressing
ALT+CursorUp/Down - the current email is closed while keeping
its status.
Saves doing ALT+SHIFT+W to keep the status and having to go to the
next email message and open it manually.
Change-Id: I21cbb042403ba84d8992e9e0878f428e38c5604c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10210
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Use B_TRANSLATE_SYSTEM_NAME in BAlert title.
* Put filenames in quotes when spaces in filename could be
confusing.
* Avoid a space at the endof a string where it could be overlooked
("Error:").
Change-Id: I7a705f4c36cbfcf27e69994b8f2126b7f6807363
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10221
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
The application name should never appear in a translatable string.
Otherwise it will always show translated in the app, even if the
user configured the Locale prefs to not "Translate app and folder
names".
Always concatenate the B_TRANSLATE_SYSTEM_NAME'ed string.
Change-Id: I511c870bef6efc11dbde52203ecd411c2009495b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10218
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
It's a good idea to be more descriptive in those file dialogs'
window title and button labels. That way you can be sure the
file dialog does what you intended.
Esp. using "Write" for the button that starts writing an image
onto a volume.
Change-Id: I0ddb71aae1962d107b8d848d772541366c6bba36
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10215
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* Assign correct MIME type for XHTML
* Fix XML encoding of '&' as '&'
* Use 'https' instead of 'http' where possible
Change-Id: I9d0628bd560b253bf9df10ed7e28eb77cf9161e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10168
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
The new "Show" filter settings:
* Desktop and non-desktop packages
* Desktop packages
* Native desktop packages
differ from the other items in the menu, as these three new items act
as radio buttons: you can only choose one. To make this more obvious, add
"only" to the menu labels:
* Desktop and non-desktop packages
* Desktop packages only
* Native desktop packages only
Change-Id: I5daac7f76317e3390c243a7ea2d9f7637e40f918
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9882
Reviewed-by: nephele nephele <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Send the proper message to open a file's parent folder and select
it, instead of employing a BMessageRunner to send the message after
0.3s in the hope the folder has finished populating by then.
Similar for the bookmarks as it was done in the Downloads window.
Changed both though to be more like Tracker's GetInfo window, which
has a bit more eleant code IMO.
Change-Id: I0cda6981500e62b81c2c2998d1cf132874eab1c2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9857
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
As PulkoMandy found out B_LONG_DATE_FORMAT corresponds to ICU's
"Abbreviated", while we want B_FULL_DATE_FORMAT (ICU's "Wide").
That is, we want e.g. "Saturday", not "Sat".
Used in WebPositive's "History" menu.
Fixes#18630.
Change-Id: Iaca93f9e34a117dae76455cde217a03dd66f08e4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9719
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Need to call BOutlineListView::AttachedToWindow() or the message
assigned by SetInvokationMessage() isn't set. Which prevents opening
a search item on double-click.
Change-Id: I3028917df075c9b10aae73747100081c48ef1dac
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9710
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
A right-click opens a popup menu with useful items of the "Actions"
menu of the main window menu.
Change-Id: Ie2eb832fee48d642cec66f0a3c7212570eedb6c0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9657
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
"Show in Tracker" or "Trim to selection" actions don't work when
applied to selected sub-items. With this change, we get the top-level
item of those sub-items to get to the file's path to fix this.
Change-Id: Idfda52d7cbd04598e52f6226f422f3afc6895d75
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9659
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Show icons for menu items of supported applications in ShowImage
and FileTypes preferences.
Change-Id: I10dbdfef3f7815f7b21d141648ae78dad5fd9993
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9517
Reviewed-by: waddlesplash <[email protected]>
Duplicates can arise if e.g. you have backup of your contacts mounted.
Or, imagine someone packages a Person file with their software as it
was common back in the BeOS days. If you have several software packages
from that dev, you'll see copies of that Person file from each package.
If a contact has the same name, we compare all email addresses. If they
differ, a new item is created. That way, Person files with more than
one email attribute ("META:email{n}" with n >= 2), as used by other apps
like Peeps!, get an item per address.
When checking for email addresses in AddPersonAddresses(), don't quit
looking through the attributes when encountering an empty one via "break".
Do "continue" with the next "META:email{n}" attribute, as it's possible
META:email2 is empty, but META:email3 has an address.
Change-Id: I644cfa2d8349b5022ffde37344c55a54577b12f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9331
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Other contacts apps like Peeps! allow for more than one email
addresses, using the attributes META:email{n} with n >=2.
Only, not all contacts having those additional attributes have
them actually filled.
This results duplicate entries in e.g. the To-field pop-up with
no email address attached.
We now only add an item if its email address isn't empty for those
additional email attributes as well.
Change-Id: Icb1750fe8e2b10280bc01b3181b444f01096e021
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9329
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Before, when you got multiple emails open, doing e.g. a "Close and
leave as New" (SHIFT + ALT + W) would correctly leave the active email
with status "New", but the other open Mail windows were closed as well
and got the status "Read"!
Now we only close the current Mail window, not the whole app and with
it all open email windows.
The currently somewhat hidden command "SHIFT + ALT + Q" now issues
a message to all open Mail windows to close and keep their mails' status,
i.e. the same as invoking SHIFT + ALT + W in all open email windows.
Change-Id: I0402a1e39ce58b53eca2c3bfe8f8becd5529c566
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9305
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Move back and forth in the search history with CursorUp/Down.
Entering a search text will reset the current history index
(fCurrentHistoryIndex = -1), and you'll be back to the first
history item next time you CursorUp.
Change-Id: Id45a47756b4732ae6e22e5373c4db5249c8df198
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9303
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
There's no B_*_SOUNDS_DIRECTORY unless a package creates
it. Check all locations (B_FIND_PATH_SOUNDS_DIRECTORY)
and set the first found as default folder for the file
dialog.
If none are found filepanels default to B_USER_DIRECTORY.
Change-Id: I26d063ba46f8c3bd83df68677b86751e1dd7c6cb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8957
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Shows up in the Locale preferences.
Add comment that data is sorted by ID in CountryFlags.rdef.
That way it's clear what's the next ID for a new flag, you
just add it with the next ID at the end of the file.
Fixes#19494
Change-Id: I0946730d07c89001331552b5026c0003c298de4a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9140
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
The new "-n" parameter waits for the networking to be up.
Code lifted from SoftwareUpdater.
To avoid polling the network status, use start_watching_network().
As this involves messaging, a BApplication is created and a
BMessageRunner is now used to regularly check if threads or
apps have started/ended.
Change-Id: I55b5174dbdbd326d8d40b958ebf966f8fa6718b3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9067
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
"Show in Tracker" opens and selects a bookmark in Tracker. Useful
if "Rename" isn't good enough, when you need to edit the URL, Title,
or Keywords attributes.
Fixes a crash when trying to "Rename" a folder. Folders were added
without a message before, so trying to access them to FindRef() lead
to a crash.
Folders are now added with a message kFolderMsg which is also used
to identify them as folders (instead of checking if their message
is NULL as before).
It's not uncommon to have symlinks in the Bookmark bar. We now don't
traverse those to their origin when renaming or deleting, so only
the files in the "Bookmark bar" folder are affected, not the original
files.
Only when adding an item, we traverse a symlink for its icon.
Change-Id: I3f420995cf5c12930a1cf3a00bb4257d19c4d5a6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8772
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
When you download a file, the Downloads window is opened to show
the progress etc. This is good, but once opened, it shouldn't
get activated (= pop to the front and getting focus) for each
new download. Often you've continued scrolling a webpage and when
the download finally starts, the DL window steals the focus...
Change-Id: Icdbd6bc5e2f0441eff650428834348f3fb508906
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8799
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* Sentence casing
* Sort "Delete" in context menu to the bottom.
* Added BSeparator before "Delete" item to have this destructive
action stand out.
* As bookmarks often have spaces, put their path/name in quotes.
* A bookmark path can be long, better start it in a new line.
* If the bookmark was successfully deleted, but removing it from
the bookmark bar failed, we don't need to add the full path to
the alert text, just use the name (= Leaf()).
* Fixed wording of error text when removing a bookmark from the bar.
Change-Id: Ie3cf32325bf77ca9fa5b60e3a49f02baae268090
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8771
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Having "Notification" at the beginning of the sound names makes
sure their entries in the Sounds preferences are always next to each
other.
Change-Id: Ia47431ecd4c5e8c346f1417a4d29a151c06217cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8737
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Fredrik Holmqvist <[email protected]>
* Using "SndFilePanel" from Be Sample Code by Todd Thomas with only
small changes.
* Removed check for audio file in B_REFS_RECEIVED, because the file
panel uses a BRefsFilter.
* Reset file panel location in case the panel was canceled.
* Use entry.IsDirectory() instead of entry.GetStat() for simplicity.
Change-Id: Ibb4a4cb8e3c4b60c85a9ba0b2e5287416bbc4b44
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8736
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Besides the already set sound files, the Sounds popup menu shows
the files of all the B_*_SOUNDS_DIRECTORY.
As people/packages may sort sound themes in sub-folders there, only
add files from there to the menu, no folders.
Change-Id: I79cda5d547fc1a0ec0234384e3b76f2c455b2881
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8722
Reviewed-by: waddlesplash <[email protected]>
* Default to B_SYSTEM_SOUNDS_DIRECTORY (if it doen't exist, the
home folder gets set automatically).
* Save the last used path in the Sounds_Settings file.
* If the last used path isn't valid any more, default to
B_SYSTEM_SOUNDS_DIRECTORY.
Change-Id: I90bf7e640e648e6e7dfc2941440550cb074c18f0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8704
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* A new icon to indicate native apps in HaikuDepot. It's simply the
Overlay_leaf on a blue disk.
* Slight change to HaikuDepot_Installed to add a black outline to its
green disk. That makes is better distinguishable on similar coloured
backgrounds.
* Made the green of HaikuDepot_Installed a bit less glaring, using a
slightly light green that shown in the old Haiku Color Palette [1]
[1] https://www.haiku-os.org/files/downloads/2007-03-20_haiku-color-palette.png
Change-Id: I5c29d65e05561fafe5d84c173ddaf083281d391b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8526
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
In "by attribute" mode, the attribute popup and AND/OR popup menus
are needlessly wide, while the text input field could be wider.
This change increases the weight of the text column, making those
popup menus less wide.
Fixes#19116
Change-Id: I347583cdb7d8e399f83f56cc2d167084e1483ba8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8356
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* _DisplayPartitionError() adds quotes to the partition name variable (%s).
So when calling it, the passed string musn't have the variable in quotes
already (\"%s\") or we'll end up with duplicate quotes.
* Anywhere else we see a partition name variable, it should have quotes.
This change fixes two places that didn't before.
Change-Id: I37e806c9dceea3c2a2b52a7cb139d7c32e976d5c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8353
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* Move "Open..." menu to the top, above the save items, as is usual for
Haiku apps.
* Capitalize "Trash", as in the rest of Haiku; it's the concept of "Trash",
i.e. of all mounted volumes.
* Replace the volume-popup label "On" with "Target:". After limiting the
query to folders was added, "on" wasn't grammatically correct any more.
Change-Id: Id8a65d287af0b154956b1018599876d276a33bda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8110
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
* Add a menu item at the bottom of Tracker's "New" menu and all
submenus to "Add new submenu...".
* The menu creates a folder "New submenu" under
"~/config/settings/Tracker/Tracker New Templates" and adds the
attribute _trk/_template_submenu = true to it. That results
in showing it as a submenu in Tracker's "New" menu.
* Finally "~/config/settings/Tracker/Tracker New Templates" is
opened and selected, so the user can edit the folder name that'll
appear as submenu label in the "New" menu.
Change-Id: I1783f8a88c8e56fbe33012c7312cc97e9401f7f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7931
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
FSCreateNewFolder(): Fix entry_ref of renamed file
* If FSMakeOriginalName() renames a file, because the file name
already exists, FSCreateNewFolder() needs to set the ref to the
new filename.
* Fix copy-suffix in FSCreateNewFolder(). The space comes before the dash: " -".
Before, you ended up with "File name- 2"
FSMakeOriginalName(): Make truncation localization aware
* In FSMakeOriginalName() don't hardcode the 4 characters of "copy" when
determine to truncate an overly long filename.
* Adjust comment in that regard + typo fixes.
* Localize default suffix " copy".
Change-Id: Ica880a8b831b321657f3f2d3825509b7fb9fe72d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7960
Reviewed-by: waddlesplash <[email protected]>
Tweaking the colors for the character view.
* Don't use hard coded colors, but B_LIST_* colors.
B_LIST_* has the advantage over B_DOCUMENT_* that there's a
*_SELECTED_COLOR, too, for the the currently selected char.
* Make the disabled characters - those not part of the currently set
font, but taken from a fallback font - a bit darker. Those lacked
contrast before IMO.
* Dark themes need some special consideration when using disable_color.
They need to be lightened where bright themes get darkened.
* Added special treatment for the color of selected items. Needed
for people (e.g. me) that run a bright theme (= dark text on light
background), but have light text on dark background for selected items.
Fixes#18948
Change-Id: I44e5be6a38e1d531238889b96ca65db0cf49b83f
Change-Id: Ic02ced0540edf29808fcead5dec64758a963e7e3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7841
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
There seem to be no obvious alternatives to the URLs for:
* Bitstream Charter
* GLU
* Ralink
Those URLs were removed.
Fixes#18932
Change-Id: I20a1a9e4d4808f5f6cbaa0f34f2aaf24be8f90f3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7831
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
When you add two crosshairs to measure pixels, it was a bit confusing to see:
1) x: 14 y: 11 x: 19
2) x: 33 y: 20 y: 9
Now it's:
➀ x: 14, y: 11
width: 19, height: 9
➁ x: 33, y: 20
"1)" and "2)" got replaced by dingbats numbers in a circle.
Change-Id: I7fd1b3bd7869a3251e15e249f74916150eef8218
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7724
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
"New player" in MediaPlayer and "Get info" in ShowImage do exactly
like the item says, so no ellipsis needed. Similar to Terminal's
"New Terminal" and Trackers "Get info".
Change-Id: I32e59e219af7a09bd74b489459281cc71cbffd9c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7783
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
* Use B_DOCUMENT_TEXT_COLOR and B_DOCUMENT_BACKGROUND_COLOR instead
of black on white in text views.
* Depending on HAIKU_DISTRO_COMPATIBILITY_OFFICIAL build flag, either
show the official Haiku logo or the Walter logo.
* If the official Haiku logo is used, show a version with black letters
if B_DOCUMENT_BACKGROUND_COLOR is light, and white letters if it's not.
* Remove the "installer" versions of the black-on-white Haiku logo.
Instead introduce "black|white-on-transparent" logos with a
transparent background.
* Fixed the leave shadows in logo Wonderbrush files. Especially the
yellow leave's shadow appeared too large and blurry.
Change-Id: I6d3ac384d2c96d91d35e6d6e85025c9e2064d59e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7419
Reviewed-by: waddlesplash <[email protected]>
While it's obvious which link is broken when the user double-clicks it,
it isn't when the link was tried to be opened by a script, or the
launch_daemon etc.
In case resolving a symlink fails, offer a button to call Tracker's
"Get info" panel with the broken link that has info about the link and
its target.
Change-Id: Id878d0ea3da0db65ade21dd4656c18ecba585784
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7434
Reviewed-by: waddlesplash <[email protected]>
The list of supporting applications is generated case-insensitive
by making all items lowercase, see
src/kits/storage/mime/SupportingApps.cpp:302
Force the MIME type to lowercase before calling GetSupportingApps()
or a MIME containing uppercase isn't found.
Fixes#18752
Change-Id: I38252cd1be8f059d7df4bf8775855b6343a489c0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7340
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Better visible "swishy" lines that represent windows on another
workspace.
Deskbar_Window_Switch_Overlay are just the swishy lines.
Moved the windows of Deskbar_Window_Hidden and Deskbar_Window_Visible
to the right, so overlay lines can be simply "appended" in IOM.
Fixes#18727
Change-Id: I08eabd0f2e95a23921caf968ac73abf7758ae7ce
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7280
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
The folder name "Bookmark bar" should never be translated.
If it is, the folder won't be found, the bookmark bar never shown and
the menu item "Show bookmark bar" always disabled.
Change-Id: I0fb5bc6d4027c7fa957205c1da72c2fabd9e122e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7204
Reviewed-by: waddlesplash <[email protected]>
The image was placed 1 pixel to the right, resulting in a grey
vertical line appearing to the left of the image.
Fixes#18679
Change-Id: I02b1cb6bc898c48ff73ae114b2cda368ea636de7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7118
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
As investigated and suggested by jackburton in ticket #14693:
outTranslator wasn't initialized correctly (due to type mismatch
on 64 bit platform).
Also set the image's file name as default in the save dialog.
Fixes#14693
Change-Id: I741e3616b935315a707ea3949a330d41d577fd91
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7102
Reviewed-by: waddlesplash <[email protected]>
Besides the entry_ref to an existing Person file as argv, also
accept a BMessage containing values for attributes and set those
in the new window.
The specifier name in the BMessage needs to be the same as the
attribute name used by the People app, e.g. "META:email".
Needed to let the Mail app create a new Person file with the email
address already filled in.
Fixes#14766
Change-Id: I637200b08d5c1b7cf52d7cf3f56dab93ce1a6ec5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7085
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
If a Person file with the selected email address doesn't exist yet,
launch the People app with a BMessage "M_LAUNCH_PEOPLE" that triggers
the People app to create a new Person file.
The message includes "META:email" and "META:name" for email address
and contact name. The contact name may be empty, if it wasn't included
in the mail's from/to/cc etc. field.
Don't show error alert, if People was already running.
Fixes#14766
Change-Id: Id4f7ae50aa1ea283974f2fa067ac9e199f369db5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7084
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Doesn't remove the rating BFS attribute from the file, just sets it to "0".
ShowImage: Move "Ratings" menu into a new "Attributes" menu, similar to
MediaPlayer.
Change-Id: I831166d88be9d18f1d302a423aa43929b7a1b255
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7092
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
The rating now uses unicode symbol U+2BEA - "Star with Left Half Black": ⯪
for the odd rating values (ranging from 1 to 10 for up to 5 stars).
The other used symbols are still:
* U+2605 - "Black Star": ★
* U+2606 - "White Star": ☆
Fixes#12986
Change-Id: I1ea27db67131b071e827a05847595f88b6d9dcda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7091
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Rene Gollent <[email protected]>
* Moved "Use as background..." from "Image" to "File" menu.
"Image" holds items that affect the display of actual image
(rotate/flip). "Use as background..." doesn't.
* Move "Close" down above "Quit".
Change-Id: I23ddcc2cf03937322649ab289ef405f84c878dfb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7090
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Populate a new sub-menu with all applications that support the current
image's MIME type. Launch the chosen app with the image entry_ref as
B_REFS_RECEIVED message.
The sub-menu listing supporting apps is separated into apps supporting
the supertype ("image/" and full support (e.g. "image/png").
Add the new "Open with..." menu to the "File" menu and the context menu
of the image.
Most of the code was grabbed from the FileType prefs PreferredAppMenu,
therefore its copyright was copied and extended.
Change-Id: I0190cf4b78c59e429f4e67654665598340653c5d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7072
Reviewed-by: Axel Dörfler <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Addresses #15418 without completely solving it.
At least for font sizes >= 11 points it works mostly. Buttons are
no longer cut off, though the summary page showing all partitions
is taller than necessary for > 3 partitions, esp. for smaller font
sizes.
Views aren't vertically centered at least.
Change-Id: Id6224b83f27510c9ed45e303f0b5dabf47af0574
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7062
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
After the last change, korli suggested this simplification that lets
SetValue() do all the in/decrement-widget en/disabling.
Change-Id: If87579d9104bbc9ae279aa5f2f99c9921bb238ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7053
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Say you have a BSpinner with a fValue of 10 and a fMaxValue of 10.
The +-widget is correctly disabled.
If you now set the fMaxValue to 20, the +-widget stays disabled.
With this change the state of the +/- widgets are set correctly when
the Max/MinValues are changed.
Change-Id: I4dce7f0ecd6aee8e9b562618ec1367dbeb212dc4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7050
Reviewed-by: waddlesplash <[email protected]>
* Renaming "Low battery" to "Battery low" so it's right next to
"Battery charged" in the Sounds prefs event list.
* Adding "Battery critical" sound. I think it makes sense to have
a different - more urgent - sound when there's only 15% left,
compared to "Low" (30%).
Change-Id: I46b5975e5797a9c3a84d4619e697be162e79b1cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6900
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Humdinger
