Ingo Weinhold
4536dd81ff
Fixed standard 'backward iteration with unsigned var' bug.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10682 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:37:26 +00:00
Ingo Weinhold
0660acfd9c
Must have accidently implemented BQuery::Rewind() when migrating to our syscalls.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10681 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:35:48 +00:00
Ingo Weinhold
f5b1fba063
Yuck! Bad typo. I wonder why the respective unit test ever passed.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10680 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:34:28 +00:00
Ingo Weinhold
a368fecb8d
When opening the node O_RDWR failed, we try again O_RDONLY, but we did that only, if the returned error code was B_READ_ONLY_DEVICE or B_PERMISSION_DENIED. Some FS return other error codes though, so we are completely ignorant now and always retry on error. Maybe we shouldn't for obvious cases like B_ENTRY_NOT_FOUND.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10679 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:33:25 +00:00
Ingo Weinhold
51634653c6
* Fixed BMessageBody::GetInfo(): Indexed based iteration was broken for
...
two different reasons.
* Fixed BMessageBody::FindData() in case of type B_ANY_TYPE, which should
match any matchingly-named field.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10678 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:25:48 +00:00
Ingo Weinhold
c9f9a6b20d
* fReplyTo.target (the handler token) is internally checked even, if the
...
preferred handler is addressed. So make sure, it has a usable value in
this case, otherwise ReturnAddress() usually won't work.
* If the message to be read from the port is bigger than the on-stack
buffer, the chunk of memory to be allocated on the heap has to be the
size of the message, not the size of the on-stack buffer. This caused
all kind of nasty, hard-trackable problems.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10677 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:20:15 +00:00
Ingo Weinhold
c5c962d426
Enhanced debugging output to print also the thread ID.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10676 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-12 03:13:52 +00:00
Stefano Ceccherini
4339dcab52
Removed some wrong code and added a comment. Small style fixes
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10654 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-10 14:18:53 +00:00
Matthew Wilber
969d816792
Removed silly PPMTranslator hack because it caused issues with the Haiku RTF-Translator and it really never should have been added in the first place.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10586 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-05 02:14:09 +00:00
Stefano Ceccherini
4ff5ade253
Many visual fixes to BMenu. Now it's almost undistinguable from the real thing. SeparatorItems were being drawn too dark. Fixed.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10585 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-04 14:42:19 +00:00
Stefano Ceccherini
b282b9018e
Implemented separator style 2, courtesy of Olivier Milla
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10584 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-04 13:13:42 +00:00
Stefano Ceccherini
5b7528754d
The frame around the BMenu is now drawn by a special class (as happens in beos), and not by BMenu::DrawBackground(). Refactored BMenuWindow to support scrolling (not implemented yet). The AddItem() functions now call the private _AddItem(). Implemented AddList(), but it's not tested. BMenus are now offsetted by 2, 2, as in BeOS.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10582 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-04 12:59:49 +00:00
Stefano Ceccherini
1664b981f2
Added some todo items, cleanups. Removed the frame parameter from BMenuWindow as it's not needed.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10573 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-03 16:05:05 +00:00
Stefano Ceccherini
4e876d126e
implemented B_ITEMS_IN_MATRIX layout correctly. Small cleanups all around.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10571 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-03 13:33:03 +00:00
Stefano Ceccherini
9a8540fb4e
Now menuitems are highlighted correctly, and submenus open, at least.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10570 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-03 11:34:14 +00:00
Matthew Wilber
e940fe0597
Fixed button so that it stays depressed when mouse button is down, changed to support click and drag-off, centered button label vertically as Be's version is centered. Still need to add white line below focus line, need to verify the button's value is set at the correct times, need to verify that invoke is being used properly, need to test behavior and drawing when button is disabled.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10561 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-01-02 20:05:39 +00:00
Stefano Ceccherini
c38a7df2a8
Accidentally commented the DrawContent call. I promise, this is the last commit for this year.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10557 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-31 11:52:39 +00:00
Stefano Ceccherini
92aa9dcf85
some more cleanups. The AddItem() variation which accepts a BRect parameter now calls the debugger if called when the layout is not B_ITEMS_IN_MATRIX.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10556 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-31 11:44:04 +00:00
Stefano Ceccherini
9944a2998d
Now items are removed correctly. All RemoveItem() call pass now through the private RemoveItems() method. ComputeLayout now uses a switch block, and prints a warning if B_ITEMS_IN_MATRIX is used, since it's not supported yet. Some cleanups.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10555 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-31 09:44:56 +00:00
Stefano Ceccherini
7ca9166efa
Now BSeparatorItem's Draw() checks the separator type. Implemented separator type "1". Please, someone with a better "artistic" skill than me, feel free to implement separator type "2" and check if the drawing of the others is correct :)
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10554 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-31 09:04:14 +00:00
Stefano Ceccherini
efa306a09d
BMenu now does even work correctly and doesn't flicker anymore. Submenus does not yet, though, and sticky mode is not yed supported.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10553 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 15:37:33 +00:00
Stefano Ceccherini
b0d01b5f78
MenuWindow now uses the private window_feel "1025", which I guess we'll need to implement server side too, since it behaves differently than B_MODAL_WINDOW_FEEL. Menu items added to a menubar didn't appear immediately, so I forced an Invalidate(). Could be made better, I think.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10552 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 13:27:00 +00:00
Stefano Ceccherini
31e911da16
Fixed BMenuBar drawing. Managed to have BMenu working (partially) with BMenuBar.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10551 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 11:03:36 +00:00
Stefano Ceccherini
36d4f05908
Style changes, some checks for NULL values
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10549 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 10:02:39 +00:00
Stefano Ceccherini
1b925bd5ae
Moved BSeparatorItem`s implementation to its own file. Will split headers later.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10548 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 09:54:48 +00:00
Stefano Ceccherini
ddd7b87d8e
Small cleanup, added a TODO comment.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10547 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 09:42:46 +00:00
Stefano Ceccherini
a5e772c9c2
Fixed the other bug reported by Axel: the blinking caret spuriously drawn at a wrong position.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10546 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-30 07:59:24 +00:00
Stefano Ceccherini
d5aba99a5e
Refresh() has to do some operations even if there is no window available.
...
This fixes a bug in Diskprobe, thanks to Axel for reporting.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10543 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-29 11:15:22 +00:00
Stefano Ceccherini
cc9f6bbded
Implemented RestoreFocus(). Thanks to Ingo and Marc for the help
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10539 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-27 14:16:56 +00:00
Stefano Ceccherini
e411c65862
Mmmmh, I love Cut & Paste...
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10538 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-27 09:56:01 +00:00
Stefano Ceccherini
14260ebb3b
Small style changes
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10537 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-27 09:48:15 +00:00
Stefano Ceccherini
446b8c194e
Moved BMenuWindow to its own file
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10536 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-27 09:05:16 +00:00
Stefano Ceccherini
86832512bb
Now includes MenuWindow.h instead of duplicating the declaration
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10535 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-27 09:04:28 +00:00
Stefano Ceccherini
872e52f249
DOS-->BeOS endlines
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10530 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-24 17:55:42 +00:00
Stefano Ceccherini
c74996495a
Hacked BMenuBar into something working, not yet with our own BMenu but with beos's one. B_WILL_FIX our BMenu. Not everything work, though.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10529 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-24 17:45:36 +00:00
Stefano Ceccherini
baab695f35
Removed StringItem.cpp as its implementation is in ListItem.cpp
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10528 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-24 11:39:14 +00:00
Stefano Ceccherini
fd99e7194c
Made the (private) 'JAHA' message a constant, and moved it to ViewAux.h. Maybe it doesn't fit much in there, but I didn't want to create a new header just for it. Feel free to move it to a better place.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10521 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-23 14:03:28 +00:00
Stefano Ceccherini
3a15790e0f
Fixed a couple of infinite loops, small style changes
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10520 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-23 13:27:14 +00:00
Stefano Ceccherini
bc6981cc74
Switch synchronous and asynchronous mouse tracking code as it was wrongly placed. Style changes.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10517 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-23 12:13:56 +00:00
Stefano Ceccherini
3583227ca5
Style changes, moved some functionalities to private methods
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10515 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-22 10:43:40 +00:00
Stefano Ceccherini
ca8ed92280
Moved gPrivateScreen into the BPrivate namespace. Small cleanups to Application.cpp. Refined some comments. Used strdup() instead of new because it`s nicer for strings.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10514 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-21 10:44:31 +00:00
Axel Dörfler
e372dc78c8
Added handling of B_QUIT_REQUESTED messages, even if it might not be complete.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10513 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-21 01:32:55 +00:00
Axel Dörfler
50df61f891
Fixed warnings.
...
Applied our style guide.
Removed fHeight from comparisons, fSize should be enough. Clarified comparisons.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10506 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 13:56:14 +00:00
Axel Dörfler
dfb4723fdf
_kern_open_query() syscall had been changed.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10504 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 13:30:00 +00:00
Axel Dörfler
c18d84297a
Grouped all constructors together.
...
Moved InitData() to be close to the constructors.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10501 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 13:04:16 +00:00
Axel Dörfler
72f5d8600c
Moved the quit window code into window_quit_loop() which is now called by
...
quit_all_windows(). I've also implemented the file panel quit mechanism,
but I'm not sure it's correctly done yet.
The BApplication destructor now locks the looper. Added commented out
deletion of fServerTo port and a ToDo comment if this should be done.
Run() no longer checks fMsgPort somewhere, but fInitError at the beginning;
if a missing fMsgPort doesn't set this, I guess InitData() is broken (or
better, BRoster::Private::CompleteRegistration() is). It now also deletes
any fPulseRunner (could be moved to ~BApplication, though).
QuitRequested() now correctly calls quit_all_windows().
Added a question to Quit() about the usefulness of special casing calling
the function from another thread.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10500 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 12:57:00 +00:00
Axel Dörfler
af34fbf1c5
Moved the unmaintainable list of initializers for the different constructors
...
to InitData(). Also fixed the initial value of fPulseRate (was 500000 but
according to the BeBook, it should have been 0).
Implemented SetPulseRate() (untested, but should be okay).
Minor cleanup.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10499 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 11:09:56 +00:00
Axel Dörfler
beabca50a7
Collision with our style guide.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10495 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 10:30:50 +00:00
Axel Dörfler
bae6988e7d
Fixed some bugs and added some missing functionality:
...
- DispatchMessage() would swallow all handled messages, no matter if they were
intended for this handler.
- B_REFS_RECEIVED does now maintain the recent folder/document lists.
- Now calls Pulse() when a B_PULSE is received.
- No longer calls ReadyToRun() more than once, no matter how many B_READY_TO_RUN
are sent to the app.
- Added B_APP_ACTIVATED to the yet unhandled messages; furthermore, the known
unhandled messages now dump themselves to stdout.
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10494 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-20 10:04:28 +00:00
Stefano Ceccherini
6f633eb2a6
Some comments on possible changes, before I forget about them. Compacted some code.
...
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10480 a95241bf-73f2-0310-859d-f6bbb57e9c96
2004-12-17 08:29:08 +00:00