Commit Graph
100 Commits
Author SHA1 Message Date
Oliver Tappe 5cf8a6abc4 * rename 'domain'-parameter to 'packages', as that's less generic
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40221 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-12 18:06:04 +00:00
Oliver Tappe 6f8d1ab089 * implement fetching of initial domain from the mount parameters in
order to be able to mount packages from somewhere else than
  '/boot/common/packages' (squashes a TODO)
* squashed another TODO about needing to remove nodes of already 
  installed packages if anything goes wrong during the activation
  of a package domain
* fix what to me looks like a bug in Volume::AddPackageDomainJob::Do(),
  fDomain is accessed unconditionally in the destructor, so NULLing
  it here is bad (it doesn't make sense from a reference-passing POV
  either). The problem never showed as this code is never being executed
  currently (no way to add additional package domains as of yet)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40214 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-12 14:56:41 +00:00
Oliver Tappe b29f1f4498 * support "." as parameter when creating a package, in order to
simplify creating a package for the contents of the current folder

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40213 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-12 14:45:57 +00:00
Oliver Tappe 170c1cc032 * fix check in PackageWriter against ".."
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40212 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-12 14:28:58 +00:00
Oliver Tappe afd785cf43 * fix build of app-server in debug mode - thanks to Timothy Brown
(stimut) for the hint that it was broken

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40190 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-10 13:37:45 +00:00
Oliver Tappe db03311342 Closing #7056:
* inherit umask of calling process to images loaded via exec...()

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40071 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-02 19:12:19 +00:00
Oliver Tappe bd2a7a1a44 Closing #3145:
* apply a patch by hamish (as part of GCI) that lets fseek() discard 
  characters pushed onto the stream via ungetc()

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40055 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-01 19:04:32 +00:00
Oliver Tappe cda7f65b32 * add fseek_test, which exposes a problem described in #3145
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40054 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-01-01 18:56:06 +00:00
Oliver Tappe 08f914dc67 Fix CID-8112 & -8113 (strange pointer arithmetic)
* BShape:: AddShape(): drop manual multiplication in typed pointer 
  arithmetic - addding the number of elements to a typed pointer
  will already move that pointer in steps of sizeof(type). 
The effect of this bug would be overwritten memory somewhere behind the data array.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39951 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 15:50:08 +00:00
Oliver Tappe 9201344705 Fix CID-5893 (resource leak):
* close the dlopen()-ed image if the locale backend could not be created


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39950 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 15:26:58 +00:00
Oliver Tappe 4167bb128b Fix CID-34 (dead code):
* eliminate code that will never be reached

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39949 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 15:19:12 +00:00
Oliver Tappe b97c958d25 Adjust for CID-8007:
use strlcpy() instead of strcpy() for improved clarity, although
the buffer is always wide enough [famous last words ...]

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39948 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 14:53:39 +00:00
Oliver Tappe 420e9637fe Fix CID-10224 (uninitialized member in c'tor):
* drop fShowFocus, as it is only used in a single method
* initialize fHoldValue

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39947 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 14:34:26 +00:00
Oliver Tappe 4a08647e39 Fix CID-4185 (expression can't be true):
* drop superfluous checking of uint32 < 0

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39946 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 14:25:05 +00:00
Oliver Tappe e9bcfa8975 Fix CID-10211 (uninitialized member in c'tor):
* fDropIndex should be initialized

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39944 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 14:21:30 +00:00
Oliver Tappe ce5bc205b1 * drop TODO as it doesn't apply - catalogs have nothing to do with ICU
and there are no catalog-specializations for encoding or currency

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39943 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 14:01:11 +00:00
Oliver Tappe fc6502a69f Fix CID-10337 (unreachable code):
* only return the catalog if it isn't NULL, thus allowing the loop 
  to potentially increase the loop var - in turn making code reachable
  that wasn't before


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39942 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-26 13:58:57 +00:00
Oliver Tappe cac8f7d4d3 Fix CID-10553:
* avoid possible use of deleted catalog (didn't occur because we
  currently only have a single type of catalog add-on)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39923 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 23:04:28 +00:00
Oliver Tappe 0119051c93 Fix CID-2358:
* check result of BMessage::FindString() (plus more ...)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39922 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:44:31 +00:00
Oliver Tappe c905e535a2 Fix CID-5982-5985:
* assign arrays members explicitly instead in initialization list


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39921 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:39:17 +00:00
Oliver Tappe abd80e8a97 Fix CID-9827:
* the unarchival constructor didn't initialize some members

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39920 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 22:08:33 +00:00
Oliver Tappe aa754a906b Fix CID-2460:
* check result of BMessage::FindString() (plus more ...)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39919 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-22 21:41:10 +00:00
Oliver Tappe b27cf34dc1 Close #6969 (warning about redundant declarations):
* drop function declarations from wctype.h which are already in wchar.h

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39917 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-12-21 23:13:47 +00:00
Oliver Tappe eaab4bd5e9 Fix #6758:
* adjust TruncTimeBase() in libtracker's WidgetAttributeText to use
  the BString-based versions of BLocale's date formatting methods
* restored the 6 different formats Tracker used to try and fit into
  a date column (i. e. it now behaves pretty much as it did before the 
  introduction of the Locale Kit)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39649 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-26 15:22:40 +00:00
Oliver Tappe de2e54ace0 Adjust tzset() implementation to better follow the POSIX specs and
make some more perl tests happy.
* no longer expect a ICU timezone ID in the TZ environment variable,
  but only expect this format if the TZ-value is starting with ':'
* accept "standard" TZ-values like "EST5" (of which only "EST" is
  relevant to us) - if such a value is specified, we hardcode the
  timezone name to the given value, no matter how ICU calls it
* adjust tests accordingly


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39415 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-13 01:13:38 +00:00
Oliver Tappe bc3791e867 * add symbolic constants for the langinfo constants, as that's what
is required by the POSIX specs (and some perl tests rely on it)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39413 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-13 00:22:40 +00:00
Oliver Tappe 5ae9cf0060 * fix warning about deprecated conversion
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39412 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-13 00:21:23 +00:00
Oliver Tappe 612333a601 Fix crash reported in #6805:
* check if we actually have a selected item

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39382 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-09 22:08:35 +00:00
Oliver Tappe bd13a264f7 Fix #6740:
* remove declaration of ctype-..._l() functions, as we do not provide
  them and they are not really needed by our hacked glibc
* replace remaining invocations of isspace_l() and isupper_l() in glibc
  with isspace() and isupper() respectively
This allows libroot to be built in DEBUG mode, again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39380 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-11-09 21:36:35 +00:00
Oliver Tappe 6fd2f4a0d1 One more monster commit (sorry ...) concerning the Locale Kit:
* extracted new class BFormattingConventions from BCountry, which
  manages the formatting conventions from a given locale and 
  allows to get/set the four different date/time formats supported
  by ICU-locales as well as number and monetary formats
* overhauled the Locale preflet:
  + drop editing features for all formats, since I don't think
    they do not make much sense to have in a prefs GUI - being
    able to select from the existing locales should be good
    enough. Please note that you can still change the formats
    programmatically in an application.
  + renamed the 'Countries' tab to 'Formatting'
  + the locale formatting conventions list in the 'Formatting'
    tab is now hierarchical for easier access (less scrolling)
  + fixed functionality of 'Revert' and 'Defaults' buttons
  + added support for using the month/day-names of your preferred
    language during date formatting
* adjusted BLocale to ask BFormattingConventions for the current
  formats when formatting dates and times and to offer 4
  different format styles (full, long, medium and short).
* adjust all classes formatting dates/times to pick the 
  appropriate format style
* BLocaleRoster no longer directly archives/unarchives the 
  individual formatting conventions but delegates that to
  BFormattingConventions
    

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39123 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-24 12:57:55 +00:00
Oliver Tappe b0c3ed0447 * fix a couple of typos
* removed a sentence that's no longer true

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39024 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-20 17:32:29 +00:00
Oliver Tappe 6f43fabafb * some cleanup in BLocaleRoster
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39018 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-20 09:23:06 +00:00
Oliver Tappe c0ea325df9 * fix sorting of languages in ReadOnlyBootPrompt
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39014 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-19 21:59:58 +00:00
Oliver Tappe d1d8fda637 Next step of Locale Kit refactoring:
* BLocale now keeps language and country completely separate and
  mixes the formatting conventions into the current language's locale
  when formatting dates and times (needs to be done for number- and
  currency-formatting, too, since the digits may not be in the
  preferred language)
* optimized fetching of the flag icons such that they are all loaded
  in one go (by the locale roster) - this alone speeds up the Locale
  preflet considerably
* worked on fixing the language confusion in the Locale preflet
* fixed a couple of bugs in the Locale preflet that would lead to
  illegal characters being displayed in the date-subpart menus


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39013 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-19 21:36:44 +00:00
Oliver Tappe 72cf60a534 * replace glibc-base wcwidth() and wcswidth() with the one from
Bruno Haible's libunistring, which seems to work just fine

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38936 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-10 17:49:09 +00:00
Oliver Tappe fdb863b626 * added tests for wcwidth() to locale_test that expose the pretty
drastic failure to handle anything else than ascii chars.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38934 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-10 15:07:36 +00:00
Oliver Tappe 6a5dacaa3c part1 of fixing #6599:
* protect against invocations of ctype-macros/-functions with negative
  character indices by mirroring the corresponding values at negative
  array indices (the legal access range of __ctype_b is now [-128..255])


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38708 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-18 15:55:42 +00:00
Oliver Tappe 4a0b7d1bd0 * don't try to check __isctype((char)255), as it will clash with
neutral/identity value at -1 (EOF)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38707 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-18 15:51:37 +00:00
Oliver Tappe 611e1071a7 * add ctype-related tests that expose the cause of #6599
* fix warnings

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38704 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-18 14:31:13 +00:00
Oliver Tappe 338ddd836f Closing #6499:
* add missing getsubopt() POSIX-function
* added corresponding test


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38650 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-14 18:43:24 +00:00
Oliver Tappe 86932f41cc Try to fix #6581:
* avoid trying to overwrite values of a constant structure when
  updating the numeric locale data values used by glibc


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38623 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-12 17:24:38 +00:00
Oliver Tappe 5d46644f18 * added tests for localized numerical formatting via printf()
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38622 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-12 17:21:28 +00:00
Oliver Tappe ccee6057f0 * fix wrong signedness in values put into global 'timezone' variable,
the POSIX specs are a bit vague on this (to say the least)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38606 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-11 18:34:48 +00:00
Oliver Tappe 69b46b571e * improved ParseDateTest to check several different timezones
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38605 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-09-11 18:32:34 +00:00
Oliver Tappe b7f609650b * removed all BLocale-related getters from BLocaleRoster - they're available
in BLocale (which is accessible via be_locale)
* adjusted all users accordingly


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38459 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-30 19:58:19 +00:00
Oliver Tappe 2bd0cd6cb8 * improved const-correctness of BLocale
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38457 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-30 18:57:17 +00:00
Oliver Tappe 6bb481c714 Adjustments to Locale preflet
* renamed Locale.{h,cpp} to LocalePreflet.{h,cpp} as having two headers named
  Locale.h confuses jam (as a result, the Locale preflet did not depend on
  headers/os/locale/Locale.h)
* style adjustments (mostly order of headers)
  

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38455 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-30 18:27:12 +00:00
Oliver Tappe 9a00115643 Last part of #3298:
* applied patch by VinDuv that adds a Perl-based implementation of readlink,
  which is needed on Mac OX X, as that doesn't have any of the other fallbacks
  - thanks!
IIRC, other people have managed to configure without this on Mac OS X, but
I suppose no harm can be done by providing this as last resort.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38454 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-30 16:17:36 +00:00
Oliver Tappe 6e30c4b8af * rename BTimeZone::Accessor to BTimeZone::Private to match the other
private accessor classes
* adjust style in BTimeZone::Private implementation to match other classes
  of this kind


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38449 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-30 14:30:22 +00:00
Oliver Tappe a9faf94392 * reintroduced be_locale as global information point for the current locale
values
* added locking to BLocale (needed since the data of the global object may
  change any time)
* BLocale no longer passes out pointers to internal objects, it fill objects
  passed in by the client instead (just like be_locale_roster does)
* dropped default language as member from RosterData, it is no part of the
  default locale
* fleshed out implementation of TimeUnitFormat and DurationFormat, both
  of which can now be given a BLocale in order to set the strings being used
  during formatting


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38428 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-29 20:55:00 +00:00
Oliver Tappe 279125fbd9 * added BTimeZone::Accessor class, which allows other LocaleKit classes to
access a BTimeZone's ICU-timeZone 

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38427 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-29 20:52:28 +00:00
Oliver Tappe f3dd81ab9b * style adjustments
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38426 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-29 20:40:15 +00:00
Oliver Tappe f059c93c7d * minor cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38414 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-28 09:36:59 +00:00
Oliver Tappe 81fe5a9200 * re-added GetAvailableTimeZones() to BCountry - it is now a convenience wrapper
around BLocaleRoster::GetAvailableTimeZonesForCountry()
* minor cleanup

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38412 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-28 09:23:26 +00:00
Oliver Tappe 8b31c7e7aa * oops - removed debug leftover
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38385 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-27 00:58:34 +00:00
Oliver Tappe 540cbcd8e6 * add explicit check against mismatching version of legacy compiler, avoids
trying to build the compiler when it's not going to work


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38384 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-27 00:57:11 +00:00
Oliver Tappe 3740f52dca More Time preflet improvements:
* fixed another instance of BToolTip deletion, when we should be releasing
  a reference instead (the first one was fixed by Rene - thanks BTW!)
* brought BCountry back into the game, such that the localized name of the
  country is now being used, where possible (avoiding the " Time" suffixes
  in English)
* country-items containing only one timezone are now being filtered (the 
  timezone moves up one level, replacing the country item, but adopting
  the country's name)
* added the date to the timezone-item's tooltip, in order to make it obvious
  which timezone is "before" and which is "behind" the date-borderline
I'm pretty happy with how it works now - what's yet missing is conversion of
the preflet to the layout kit and localization of the GUI.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38382 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-26 22:27:25 +00:00
Oliver Tappe 9ef134d918 * added timezone-support to some more date/time-formatting methods in BLocale
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38381 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-26 22:17:40 +00:00
Oliver Tappe c91aa9f4e6 * moved support for getting timezones-by-country from BCountry to LocaleRoster,
since we'd like to be able to get the timezones of the global (i.e. empty)
  country, too.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38380 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-26 22:16:40 +00:00
Oliver Tappe 447b7fded1 More work on Time preflet
* update the times shown on timezone page when the user switches RTC between
  GMT/Local Time
* rename "Etc"-region to "<Other>" and sort it at the end of the list
* add current time of the corresponding zone to tooltip of a timezone-listitem
* show timezone names in the default language - not the default locale, as
  the latter is just responsible for date/time and numeric formats
This works, but the localized names are sometimes a bit strange (for instance
in English, whose timezone names have a superfluous ' Time' prefix).
I am going to experiment with mixing country information back into the game, next.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38357 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-25 17:34:54 +00:00
Oliver Tappe aa8372c486 * changed BTimeZone to use BLanguage instead of BLocale, as that what represents
the locale of messages (timezone names in this case)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38340 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-24 18:32:59 +00:00
Oliver Tappe 3bdedcf3f1 * added support for getting the names of a timezone for a specific locale
(not currently used anywhere, but should be part of the BTimeZone interface)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38333 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-24 15:03:54 +00:00
Oliver Tappe 7244db260e Fix regression introduced with r38322
* the chosen preferred languages weren't restored in Locale preflet

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38325 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-23 20:48:52 +00:00
Oliver Tappe 750e57b842 Optimized Time preflet:
* use upon-demand initialization in BTimeZone to avoid unnecessary work
* renamed BTimeZone::Code() to BTimeZone::ID() and adjusted all callers
* avoid using BCountry in the Time preflet for the time being, this means
  the icon-flags are gone for now (but they could be re-added if the demand
  is pressing ;-)
* group the timezones by regions and then by country instead
The performance improvement is considerable and I personally think the new grouping is an improvement, too. Please share your thoughts!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38322 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-23 15:17:49 +00:00
Oliver Tappe 039ad7e757 Added support for getting a list of all available timezone IDs to LocaleRoster.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38321 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-23 14:46:54 +00:00
Oliver Tappe 34d9bfb077 Missed this when working on warnings a couple of days ago:
* enable -Werror for print add-ons and wonderbrush translator add-on

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38320 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-23 14:40:29 +00:00
Oliver Tappe 258b762aef * fix a warning in the wonderbrush translator which I think indicates an actual
problem (since + binds stronger than >>)
Stephan: please review, esp since I don't know how to test this!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38279 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 19:40:15 +00:00
Oliver Tappe 36947c7bf0 * style adjustments - no functional change
Stephan: please yell if you dislike the formatting of the large expressions now

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38278 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 19:33:54 +00:00
Oliver Tappe 9c2f1fefe0 * fix non-word in comment that seems to be the result of a search'n'replace
* style adjustments

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38277 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 18:00:01 +00:00
Oliver Tappe 98dc6a20ef * fix 'uninitialized'-warnings in launchpad
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38276 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:41:11 +00:00
Oliver Tappe eba0c4d6d7 * enabled -Werror for all apps
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38275 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:36:23 +00:00
Oliver Tappe c84df63fc2 * fixed warnings in 3dmov
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38274 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:18:55 +00:00
Oliver Tappe ba2f29ad26 * fix warnings in poorman
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38273 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:09:29 +00:00
Oliver Tappe aae7a46913 * fix warnings in mediaplayer
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38272 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 17:03:06 +00:00
Oliver Tappe b401b82842 * fix warnings in mail
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38271 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:47:10 +00:00
Oliver Tappe 6ff66b0bc0 * fixed warnings in icon-o-matic (one of which was actually a style issue ;-)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38270 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:35:07 +00:00
Oliver Tappe 4b920fd031 * fix warnings in diskusage
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38269 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 16:28:42 +00:00
Oliver Tappe 7f2103fe25 Fix warnings in charactermap
* no need to overload ScrollTo() with a non-related method - renamed local
  ScrollTo() to ScrollToBlock()


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38268 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:59:50 +00:00
Oliver Tappe 3605272d0f * turns out src/kits/tracker was low hanging fruit, as it didn't contain any
warnings at all - enabled -Werror for all kits

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38267 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:54:21 +00:00
Oliver Tappe 1662a36480 * fix the single remaining gcc2-warning in media kit and enable -Werror for it
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38266 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:46:54 +00:00
Oliver Tappe 269ebc04b9 Fix #6373, second try
* make BDADDR_* macros refer to value types instead of addresses
* adjust all interfaces using bdaddr_t* to use (mostly const) refs instead,
  which IMHO makes the interface & code clearer
* that got rid of a couple of const incorrectness casts
* some cleanup along the way


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38265 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 15:29:02 +00:00
Oliver Tappe 32a2294fdc * revert r38213, as it introduces initialization problems
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38263 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-19 14:40:17 +00:00
Oliver Tappe 8f88fe1d98 * fix CID-258: BView::SetViewOverlay() shouldn't crash if given a NULL bitmap.
Coverity was complaining because we did a half-ass check against NULL only to
pass that NULL pointer on to a function that deref'd it.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38248 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:55:51 +00:00
Oliver Tappe 65341d518f Someone familiar with BBitmap, please review:
* BBitmap could leak fWindow in operator=()
* two copy constructors didn't initialize the members properly, which
  could cause crashes in _CleanUp()
* minor cleanup
Actually found this while staring at CID 254-257, which were false alarm, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38246 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 19:44:15 +00:00
Oliver Tappe e1a6422727 Fix #6458 - crash in BTextView when entering Japanese characters
* when I changed InsertText() to adjust the caret position recently, I
  forgot to drop that adjustment from all callers - _HandleInputMethodChanged()
  was still doing it, leading to out of bounds access

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38243 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-18 17:33:48 +00:00
Oliver Tappe e0ef64750f * fix #6373 by switching the BD... macros to take the address of corresponding
constants, which had to be defined in several places in order to be available
  in the kernel addons, network protocols and the server/kit.
* enable -Werror for all servers

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38213 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:46:32 +00:00
Oliver Tappe 77d9a1e9bc * of course, gcc4 had more issues with the Joystick preflet
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38205 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:08:38 +00:00
Oliver Tappe f3e4c16e4c * fix warning to get really all preflets compilable
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38204 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:03:12 +00:00
Oliver Tappe 8f62243f37 * fix warnings in Keymap preflet about hidden virtual by renaming SetFont()
to SetBaseFont() (and fFont to fBaseFont)
* enabled -Werror for all preflets


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38203 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 17:37:15 +00:00
Oliver Tappe e0ae658ae2 * style adjustments - no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38201 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:53:25 +00:00
Oliver Tappe 1195f511e5 * style adjustments - no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38200 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:47:14 +00:00
Oliver Tappe 37cebf6883 * fixed all warnings in FileTypes preflet and enabled -Werror
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38199 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:41:28 +00:00
Oliver Tappe 54123ac0e8 * style adjustments - no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38197 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:25:45 +00:00
Oliver Tappe 9602d07543 CID-1512: ensure that label is never dereferenced while being NULL
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38190 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:02:37 +00:00
Oliver Tappe 2655efc395 Fixes to Notifications preflet
* CID-1501: protect against dynamic_cast potentially returning NULL
* additional style fixes
* fixed all warnings and enabled -Werror

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38188 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:56:51 +00:00
Oliver Tappe 6137279338 CID-639: Protect against FindItem() potentially returning NULL
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38187 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:42:14 +00:00
Oliver Tappe 529fd9af5d Fixed all warnings in Shortcuts preflet and enabled -Werror for it
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38186 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:35:28 +00:00
Oliver Tappe ef9095fbe2 * CID-1742: delete SortArray when we are done using it
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38185 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:07:33 +00:00
Oliver Tappe 6effcf12f2 * CID-1741: remove useless piece of code that did nothing but leak the label
* don't check against NULL before deleting fLabel

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38184 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 13:56:23 +00:00
Oliver Tappe 803a1f70aa * Refresh() should make sure to try and load both "locale" and "timezone"
settings, not give up when one is missing (like on a fresh image)
* try harder to fallback to proper default values when loading the locale
  settings file fails

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38165 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 22:48:00 +00:00