* Sentence casing
* Sort "Delete" in context menu to the bottom.
* Added BSeparator before "Delete" item to have this destructive
action stand out.
* As bookmarks often have spaces, put their path/name in quotes.
* A bookmark path can be long, better start it in a new line.
* If the bookmark was successfully deleted, but removing it from
the bookmark bar failed, we don't need to add the full path to
the alert text, just use the name (= Leaf()).
* Fixed wording of error text when removing a bookmark from the bar.
Change-Id: Ie3cf32325bf77ca9fa5b60e3a49f02baae268090
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8771
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Having "Notification" at the beginning of the sound names makes
sure their entries in the Sounds preferences are always next to each
other.
Change-Id: Ia47431ecd4c5e8c346f1417a4d29a151c06217cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8737
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Fredrik Holmqvist <[email protected]>
* Using "SndFilePanel" from Be Sample Code by Todd Thomas with only
small changes.
* Removed check for audio file in B_REFS_RECEIVED, because the file
panel uses a BRefsFilter.
* Reset file panel location in case the panel was canceled.
* Use entry.IsDirectory() instead of entry.GetStat() for simplicity.
Change-Id: Ibb4a4cb8e3c4b60c85a9ba0b2e5287416bbc4b44
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8736
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Besides the already set sound files, the Sounds popup menu shows
the files of all the B_*_SOUNDS_DIRECTORY.
As people/packages may sort sound themes in sub-folders there, only
add files from there to the menu, no folders.
Change-Id: I79cda5d547fc1a0ec0234384e3b76f2c455b2881
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8722
Reviewed-by: waddlesplash <[email protected]>
* Default to B_SYSTEM_SOUNDS_DIRECTORY (if it doen't exist, the
home folder gets set automatically).
* Save the last used path in the Sounds_Settings file.
* If the last used path isn't valid any more, default to
B_SYSTEM_SOUNDS_DIRECTORY.
Change-Id: I90bf7e640e648e6e7dfc2941440550cb074c18f0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8704
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* A new icon to indicate native apps in HaikuDepot. It's simply the
Overlay_leaf on a blue disk.
* Slight change to HaikuDepot_Installed to add a black outline to its
green disk. That makes is better distinguishable on similar coloured
backgrounds.
* Made the green of HaikuDepot_Installed a bit less glaring, using a
slightly light green that shown in the old Haiku Color Palette [1]
[1] https://www.haiku-os.org/files/downloads/2007-03-20_haiku-color-palette.png
Change-Id: I5c29d65e05561fafe5d84c173ddaf083281d391b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8526
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
In "by attribute" mode, the attribute popup and AND/OR popup menus
are needlessly wide, while the text input field could be wider.
This change increases the weight of the text column, making those
popup menus less wide.
Fixes#19116
Change-Id: I347583cdb7d8e399f83f56cc2d167084e1483ba8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8356
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* _DisplayPartitionError() adds quotes to the partition name variable (%s).
So when calling it, the passed string musn't have the variable in quotes
already (\"%s\") or we'll end up with duplicate quotes.
* Anywhere else we see a partition name variable, it should have quotes.
This change fixes two places that didn't before.
Change-Id: I37e806c9dceea3c2a2b52a7cb139d7c32e976d5c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8353
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* Move "Open..." menu to the top, above the save items, as is usual for
Haiku apps.
* Capitalize "Trash", as in the rest of Haiku; it's the concept of "Trash",
i.e. of all mounted volumes.
* Replace the volume-popup label "On" with "Target:". After limiting the
query to folders was added, "on" wasn't grammatically correct any more.
Change-Id: Id8a65d287af0b154956b1018599876d276a33bda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8110
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
* Add a menu item at the bottom of Tracker's "New" menu and all
submenus to "Add new submenu...".
* The menu creates a folder "New submenu" under
"~/config/settings/Tracker/Tracker New Templates" and adds the
attribute _trk/_template_submenu = true to it. That results
in showing it as a submenu in Tracker's "New" menu.
* Finally "~/config/settings/Tracker/Tracker New Templates" is
opened and selected, so the user can edit the folder name that'll
appear as submenu label in the "New" menu.
Change-Id: I1783f8a88c8e56fbe33012c7312cc97e9401f7f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7931
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
FSCreateNewFolder(): Fix entry_ref of renamed file
* If FSMakeOriginalName() renames a file, because the file name
already exists, FSCreateNewFolder() needs to set the ref to the
new filename.
* Fix copy-suffix in FSCreateNewFolder(). The space comes before the dash: " -".
Before, you ended up with "File name- 2"
FSMakeOriginalName(): Make truncation localization aware
* In FSMakeOriginalName() don't hardcode the 4 characters of "copy" when
determine to truncate an overly long filename.
* Adjust comment in that regard + typo fixes.
* Localize default suffix " copy".
Change-Id: Ica880a8b831b321657f3f2d3825509b7fb9fe72d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7960
Reviewed-by: waddlesplash <[email protected]>
Tweaking the colors for the character view.
* Don't use hard coded colors, but B_LIST_* colors.
B_LIST_* has the advantage over B_DOCUMENT_* that there's a
*_SELECTED_COLOR, too, for the the currently selected char.
* Make the disabled characters - those not part of the currently set
font, but taken from a fallback font - a bit darker. Those lacked
contrast before IMO.
* Dark themes need some special consideration when using disable_color.
They need to be lightened where bright themes get darkened.
* Added special treatment for the color of selected items. Needed
for people (e.g. me) that run a bright theme (= dark text on light
background), but have light text on dark background for selected items.
Fixes#18948
Change-Id: I44e5be6a38e1d531238889b96ca65db0cf49b83f
Change-Id: Ic02ced0540edf29808fcead5dec64758a963e7e3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7841
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
There seem to be no obvious alternatives to the URLs for:
* Bitstream Charter
* GLU
* Ralink
Those URLs were removed.
Fixes#18932
Change-Id: I20a1a9e4d4808f5f6cbaa0f34f2aaf24be8f90f3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7831
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
When you add two crosshairs to measure pixels, it was a bit confusing to see:
1) x: 14 y: 11 x: 19
2) x: 33 y: 20 y: 9
Now it's:
➀ x: 14, y: 11
width: 19, height: 9
➁ x: 33, y: 20
"1)" and "2)" got replaced by dingbats numbers in a circle.
Change-Id: I7fd1b3bd7869a3251e15e249f74916150eef8218
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7724
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
"New player" in MediaPlayer and "Get info" in ShowImage do exactly
like the item says, so no ellipsis needed. Similar to Terminal's
"New Terminal" and Trackers "Get info".
Change-Id: I32e59e219af7a09bd74b489459281cc71cbffd9c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7783
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
* Use B_DOCUMENT_TEXT_COLOR and B_DOCUMENT_BACKGROUND_COLOR instead
of black on white in text views.
* Depending on HAIKU_DISTRO_COMPATIBILITY_OFFICIAL build flag, either
show the official Haiku logo or the Walter logo.
* If the official Haiku logo is used, show a version with black letters
if B_DOCUMENT_BACKGROUND_COLOR is light, and white letters if it's not.
* Remove the "installer" versions of the black-on-white Haiku logo.
Instead introduce "black|white-on-transparent" logos with a
transparent background.
* Fixed the leave shadows in logo Wonderbrush files. Especially the
yellow leave's shadow appeared too large and blurry.
Change-Id: I6d3ac384d2c96d91d35e6d6e85025c9e2064d59e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7419
Reviewed-by: waddlesplash <[email protected]>
While it's obvious which link is broken when the user double-clicks it,
it isn't when the link was tried to be opened by a script, or the
launch_daemon etc.
In case resolving a symlink fails, offer a button to call Tracker's
"Get info" panel with the broken link that has info about the link and
its target.
Change-Id: Id878d0ea3da0db65ade21dd4656c18ecba585784
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7434
Reviewed-by: waddlesplash <[email protected]>
The list of supporting applications is generated case-insensitive
by making all items lowercase, see
src/kits/storage/mime/SupportingApps.cpp:302
Force the MIME type to lowercase before calling GetSupportingApps()
or a MIME containing uppercase isn't found.
Fixes#18752
Change-Id: I38252cd1be8f059d7df4bf8775855b6343a489c0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7340
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Better visible "swishy" lines that represent windows on another
workspace.
Deskbar_Window_Switch_Overlay are just the swishy lines.
Moved the windows of Deskbar_Window_Hidden and Deskbar_Window_Visible
to the right, so overlay lines can be simply "appended" in IOM.
Fixes#18727
Change-Id: I08eabd0f2e95a23921caf968ac73abf7758ae7ce
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7280
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
The folder name "Bookmark bar" should never be translated.
If it is, the folder won't be found, the bookmark bar never shown and
the menu item "Show bookmark bar" always disabled.
Change-Id: I0fb5bc6d4027c7fa957205c1da72c2fabd9e122e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7204
Reviewed-by: waddlesplash <[email protected]>
The image was placed 1 pixel to the right, resulting in a grey
vertical line appearing to the left of the image.
Fixes#18679
Change-Id: I02b1cb6bc898c48ff73ae114b2cda368ea636de7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7118
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
As investigated and suggested by jackburton in ticket #14693:
outTranslator wasn't initialized correctly (due to type mismatch
on 64 bit platform).
Also set the image's file name as default in the save dialog.
Fixes#14693
Change-Id: I741e3616b935315a707ea3949a330d41d577fd91
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7102
Reviewed-by: waddlesplash <[email protected]>
Besides the entry_ref to an existing Person file as argv, also
accept a BMessage containing values for attributes and set those
in the new window.
The specifier name in the BMessage needs to be the same as the
attribute name used by the People app, e.g. "META:email".
Needed to let the Mail app create a new Person file with the email
address already filled in.
Fixes#14766
Change-Id: I637200b08d5c1b7cf52d7cf3f56dab93ce1a6ec5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7085
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
If a Person file with the selected email address doesn't exist yet,
launch the People app with a BMessage "M_LAUNCH_PEOPLE" that triggers
the People app to create a new Person file.
The message includes "META:email" and "META:name" for email address
and contact name. The contact name may be empty, if it wasn't included
in the mail's from/to/cc etc. field.
Don't show error alert, if People was already running.
Fixes#14766
Change-Id: Id4f7ae50aa1ea283974f2fa067ac9e199f369db5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7084
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Doesn't remove the rating BFS attribute from the file, just sets it to "0".
ShowImage: Move "Ratings" menu into a new "Attributes" menu, similar to
MediaPlayer.
Change-Id: I831166d88be9d18f1d302a423aa43929b7a1b255
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7092
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
The rating now uses unicode symbol U+2BEA - "Star with Left Half Black": ⯪
for the odd rating values (ranging from 1 to 10 for up to 5 stars).
The other used symbols are still:
* U+2605 - "Black Star": ★
* U+2606 - "White Star": ☆
Fixes#12986
Change-Id: I1ea27db67131b071e827a05847595f88b6d9dcda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7091
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Rene Gollent <[email protected]>
* Moved "Use as background..." from "Image" to "File" menu.
"Image" holds items that affect the display of actual image
(rotate/flip). "Use as background..." doesn't.
* Move "Close" down above "Quit".
Change-Id: I23ddcc2cf03937322649ab289ef405f84c878dfb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7090
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Populate a new sub-menu with all applications that support the current
image's MIME type. Launch the chosen app with the image entry_ref as
B_REFS_RECEIVED message.
The sub-menu listing supporting apps is separated into apps supporting
the supertype ("image/" and full support (e.g. "image/png").
Add the new "Open with..." menu to the "File" menu and the context menu
of the image.
Most of the code was grabbed from the FileType prefs PreferredAppMenu,
therefore its copyright was copied and extended.
Change-Id: I0190cf4b78c59e429f4e67654665598340653c5d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7072
Reviewed-by: Axel Dörfler <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Addresses #15418 without completely solving it.
At least for font sizes >= 11 points it works mostly. Buttons are
no longer cut off, though the summary page showing all partitions
is taller than necessary for > 3 partitions, esp. for smaller font
sizes.
Views aren't vertically centered at least.
Change-Id: Id6224b83f27510c9ed45e303f0b5dabf47af0574
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7062
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
After the last change, korli suggested this simplification that lets
SetValue() do all the in/decrement-widget en/disabling.
Change-Id: If87579d9104bbc9ae279aa5f2f99c9921bb238ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7053
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Say you have a BSpinner with a fValue of 10 and a fMaxValue of 10.
The +-widget is correctly disabled.
If you now set the fMaxValue to 20, the +-widget stays disabled.
With this change the state of the +/- widgets are set correctly when
the Max/MinValues are changed.
Change-Id: I4dce7f0ecd6aee8e9b562618ec1367dbeb212dc4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7050
Reviewed-by: waddlesplash <[email protected]>
* Renaming "Low battery" to "Battery low" so it's right next to
"Battery charged" in the Sounds prefs event list.
* Adding "Battery critical" sound. I think it makes sense to have
a different - more urgent - sound when there's only 15% left,
compared to "Low" (30%).
Change-Id: I46b5975e5797a9c3a84d4619e697be162e79b1cf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6900
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Humdinger
