The goal is to handle `FIXME` within WorkerThread that of MMCBus.
[+] Extended SDHCIBus to have:
> private PowerOff() to clear corresponding VDD1 power bit.
> Public TerminateBus() to terminate the bus
powering off,disabling clock and interrupts.
Also called within the destructor.
[+] Extend `mmc_bus_interface` to encapsulate terminate_bus
coping the same style of other interface utilities.
[+] MMCBus can its newly added private _TerminateBus() for handling sd cards
not supporting proposed voltage range.
Testing:
- used false invokation on qemu emulated sd card to test
the termination branch.
- Successfully built and run,SD card doesn't show up in DriveSetup
- debug Log show correct power and clock bit setting(power=0xe, clock=0x800b).
Please Guide me further on more effective test method.
Change-Id: Icc8eeac97b9c96dfbf0106871d26a41d7faea5dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10622
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Resolves two possible memory leaks that could happen once the
application is closed.
Resolves the TODO: There is still a memory leak somewhere, hunt it down
Changes:
- Added a missing break statement for ATA/SCSI/IDE controllers when
parsing in addDeviceAndChildren.
- Added a cleanup loop in DeleteDevices() to delete the category header
devices.
Change-Id: I4836384aaf3fac6ba1b176247baac0239c6482cd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10813
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Make text color document text not panel text by default.
mix_colors for diff colors like we do for quote colors.
Update color formatting but not the values. Set opacity to 0xff.
grey => gray (US English standard spelling).
Change-Id: If26efe8c2d9086aa049028b396921b8702a1093e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9984
Reviewed-by: John Scipione <[email protected]>
Tested-by: Commit checker robot <[email protected]>
B_HOME and B_END are considered nav keys however they are not yet
implemented (but they were implemented on BeOS).
Change-Id: Ib30eb60ab26e1a06151836e8bc4a5ce24e403b40
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10731
Reviewed-by: John Scipione <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Also drop the long-double files from architectures where long-double
support is (currently) disabled in glibc config.h.
Should fix#19589 and other long-double related problems on
RISC-V and ARM64.
Change-Id: Ia33ce2791d812eb143b719fb61e69dbf8b70ce79
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10815
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Sam Roberts <[email protected]>
The kernel version previously differed from the userspace
version by sBootTime, which causes issues including:
- configure scripts thinking the build environment is broken
- an sBootTime-long delay between the desktop appearing
and the user gaining control
- apparent time travel
Change-Id: I8e616772631df1c40958db4f23b10cbe6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10808
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Otherwise we just spends lots of CPU time sending silence.
This also paves the way for stopping the output when all
outputs disconnect, but that's not implemented just yet.
Since this forces a wait inside the mixer for the destination
to actually start, it may help with problems like #19074.
At least in testing, without that block, I got similar symptoms
and crashes, due to the initial 0 value being used to compute
the performance times, and winding up with very incorrect times.
Note that this changes the MultiAudioNode to not really start its
timesource when it gets a TIMESOURCE_START message. Instead it waits
until it gets a regular B_START (via StartNode) message to do that.
Change-Id: I1716e347537c88dcc76163a515e7fbb8c5ccdecb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10643
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This makes for much faster lookups, and avoids the need
to allocate an array.
sizeof(BWindow) is unchanged (on x86_64, 504; on x86, 376)
so this should not break ABI/API.
Quick benchmark in Tracker:
501 lookups, before: ~488 usec
501 lookups, after: ~284 usec
Change-Id: Ica2c728f0c5957380add53e14a826a4aade52df0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10720
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
If the shortcut is not available (due to the menus not being active),
then this will make sure we handle the key regardless. If the shortcut
is active, then it'll get eaten by BWindow, and we won't get here.
Change-Id: Id6c3ae590f596481f9dfb720aa088238ccc6413c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10718
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
... because B_NO_COMMAND_KEY shortcuts don't get registered on key down
anymore, so we have to set the target right away for this to work.
Setting target in the constructor only works becauese this menu item is
not not added dynamically.
Change-Id: I368bf91e286509c2a5d584a87bda7aea48d98a4f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10803
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
... on B_RESTORE_BACKGROUND_IMAGE (which sets the Desktop color or wallpaper).
Remove kRestoreBackgroundImage, preferring the B_ version we got from
Backgrounds (and represents the same constant). Tracker already imported
this constant long ago.
Fixes#20028.
Change-Id: I6c59f4ddd1b2a7ec0d5e90fe6a8a9671dc66d50e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10729
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
- Moved former scoped IDCommand class to Commands module.
- Now the ID command expose the following info to IMAP server:
- client name, IMAP mail_daemon add-on
- os name, Haiku
Sample protocol trace for new IDCommand:
C: A0000002 ID ("name" "IMAP mail_daemon add-on" "os" "Haiku")
S: * ID ("name" "EA" "version" "COMS/EA24.10/r20260306")
IMAP server info:
name: EA
version: COMS/EA24.10/r20260306
S: A0000002 OK ID done
Change-Id: I07e3cff151ad84c68816172e4caaea04b6ca40fb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10712
Reviewed-by: nephele nephele <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This open opportunity to use extra netresolv's nsswitch modules, like libnss_mdns.so,
for zeroconf .local names resolution.
Change-Id: If71fc47d7ab066e99daa97d453e70dddc3449f71
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10667
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
For some files, devices, and directories with no xattrs xfs can set di_forkoff to 0, so make it a valid condition check in VerifyForkoff() method
Change-Id: I930529ad661c8c5f640c18b2d50dfeddfde5b7d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10655
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Per RFC 3501, a server MAY include a CAPABILITY response code in the
tagged OK response to a successful LOGIN in order to send capabilities
automatically.
The capabilities in the untagged response could be truncated to a
shorter list of capabilities meaningful to the login process.
For instance, the IMAP4rev1 server of mailo.com, a french mail provider,
returns this on LOGIN command:
C: A0000001 LOGIN "[email protected]" "XXXXXXXXX"
S: * OK [CAPABILITY IMAP4rev1 ID LITERAL+ AUTH=LOGIN AUTH=PLAIN STARTTLS] IMAP4rev1 MAILO Ready
CAPABILITY: IMAP4rev1, ID, LITERAL+, AUTH=LOGIN, AUTH=PLAIN,
STARTTLS
S: A0000001 OK [CAPABILITY IMAP4rev1 ID LITERAL+ ENABLE IDLE QUOTA
NAMESPACE SORT UIDPLUS UNSELECT UTF8=ACCEPT] Welcome
[email protected]
CAPABILITY: IMAP4rev1, ID, LITERAL+, AUTH=LOGIN, AUTH=PLAIN, STARTTLS, ENABLE, IDLE, QUOTA, NAMESPACE, SORT, UIDPLUS, UNSELECT, UTF8=ACCEPT
capabilities: IMAP4rev1, ID, LITERAL+, AUTH=LOGIN, AUTH=PLAIN, STARTTLS, ENABLE, IDLE, QUOTA, NAMESPACE, SORT, UIDPLUS, UNSELECT, UTF8=ACCEPT
As the explicit CAPABILITY command is not sent if capabilities
were retrieved from LOGIN response, before this change, the complete
capabilities were not retrieved.
This change merge capabilities from both untagged response and tagged OK
response of LOGIN command.
Also, improve server responses traces, following the RFC S: prefix.
Change-Id: Id0fc18f0913ab03d2d3f5f90b296fbb7fb89446f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10703
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This is now a POSIX method which was widely supported even before
its addition to POSIX, so using it here (including on the build
platform) should be OK.
This takes mimeset -F of the whole src/ hierarchy from around 2.8
seconds to around 2.1 (user time goes from ~1.2s to ~0.6s.) It seems
I/O is a lot of the remainder now.
Also drop the TODO comment; we don't want partial matching like that,
as the sniffing rules would not expect it.
All tests still pass.
Change-Id: Ibb190f6f9f5e73ed027e052ef665b177d3fd6f86
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10688
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Another slight optimization. The time doesn't seem to decrease much,
but this paves the way for a much more optimized scan.
Change-Id: I0fb65544524fbc9606fd84ef521b706bd9dc4d02
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10687
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
This will allow them to perform some more upfront optimizations.
Note that this change includes a slight compatibility breakage with
BeOS R5: it applies an "-i" flag in a disjunction to all patterns in
the disjunction, not just all patterns following the "-i" (I checked.)
However, as far as I can see, this feature of R5 was undocumented
(sniff rules are described in the "Release Notes" section of the Be Book
only, and "-i" isn't discussed there), and the only pattern on R5 that
appears to use them at all was the "text/html" pattern. The behavior to
apply case-insensitivity to all patterns seems unexpected, so I think
it should be OK to break compatibility in this slight way.
Change-Id: I0556d53e602bc68ae14ac21c9e226403061043a0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10686
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Otherwise, we send them out before the file is actually renamed,
and so we could send notifications with stale name values in them
(in the case of B_ENTRY_CREATED and B_ENTRY_REMOVED), or before
the file's name actually changed as visible in stat(). This way,
we send the notification only after updating the entries.
I noticed when profiling the system with ActivityMonitor running
that most of ActivityMonitor's time was spent initializing these
for the Memory view. So, instead, cache the formatters to avoid
needing to reinitialize them so often.
With the old code, if the currentErrno hadn't changed, but was in
fact re-assigned more recently than the local errno was, then we
would wind up incorrectly return the local value instead of the
system value. This was the cause of the build mimeset not working
properly when run in recursive mode on Haiku.
So, instead, create a wrapper struct to make assignment of the
local errno always pass through to the system one, so they never
get out of sync in the first place.
John Scipione