Commit Graph
100 Commits
Author SHA1 Message Date
Stefano Ceccherini 1a2a0e07c6 Check scrolling against text rect limits. Fixes bug 1240 (and maybe 1241
too)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21207 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-22 14:13:08 +00:00
Stefano Ceccherini 8184808c5f 'Sounds' is now font sensitive. Patch by Lucasz Zemczak.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21185 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-21 07:22:17 +00:00
Stefano Ceccherini 84c2abee94 Cast errors to status_t before throwing, otherwise the catch operator
won't catch them (as ints). Thanks to Ingo and Marcus for pointing out 
the problem and suggesting a solution.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21133 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-13 20:26:31 +00:00
Stefano Ceccherini 140334f858 Added error checking using exceptions
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21112 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-12 08:46:56 +00:00
Stefano Ceccherini 522528180e Check if we have a window before drawing the item in
BListView::_Deselect()


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21107 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-10 20:40:48 +00:00
Stefano Ceccherini 0d478eeb6f Avoid sending an extra (useless) B_DIRECT_MODIFY notification to the
client, when the connection is stopped. But cache the "reason" of the 
notification, and join it with the next one, when B_DIRECT_START is 
notified. Experimental, could be reverted. 


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21063 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-07 21:26:33 +00:00
Stefano Ceccherini ca3e59106d call lock/unlock_draw() in SwapBuffers too. Don't set the view color to
B_TRANSPARENT_32_BIT because it doesn't look good in direct mode. Korli, 
please review.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21062 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-07 21:21:28 +00:00
Stefano Ceccherini 652f187eee finally fixed debug output
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21061 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-07 20:49:58 +00:00
Stefano Ceccherini 1560418a27 forgot the \n
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21036 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-05 20:41:39 +00:00
Stefano Ceccherini 5115ca0858 Added optional debug output
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21035 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-05 20:03:31 +00:00
Stefano Ceccherini e6bf88d435 use the already available BLocker instead of atomic_add and a semaphore
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21025 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-04 20:52:30 +00:00
Stefano Ceccherini def763251b cleanups, updated copyrights
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21001 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-03 20:05:47 +00:00
Stefano Ceccherini 4bfa8f22df completes previous commit. Sorry for breaking the build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20998 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-03 16:34:31 +00:00
Stefano Ceccherini 107ce0bba0 Fixed a bug in selection via keyboard (the problem described in bug
#716, comment #4)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20997 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-03 15:15:23 +00:00
Stefano Ceccherini ff32e5158c ServerPicture now uses a BPositionIO object as internal storage instead
of BMallocIO. Added an additional constructor to handle a file. This is 
in preparation of implementing BView::SetDiskMode().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20996 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-05-03 14:52:13 +00:00
Stefano Ceccherini f96bec013d small cleanups. Moved some code into a _DrawLine() method.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20940 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-30 19:49:43 +00:00
Stefano Ceccherini 0d4fbcc8fe made _BInlineInput_::AddClause() more robust in low memory conditions
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20870 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-27 20:35:36 +00:00
Stefano Ceccherini effcdf2e6a Implemented locking for BGLView direct mode. Tested with GLTeapot and
GLDirectTest. Seems to work fine


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20844 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-26 20:23:10 +00:00
Stefano Ceccherini 5240f11543 Removed unused methods and variables, small style cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20843 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-26 19:51:09 +00:00
Stefano Ceccherini 8860ba90e6 If there's a opened menu, the window should "eat" the B_MOUSE_DOWN
message. This fixes bug #582 and now menus behave like on beos (or 
should, at least)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20799 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-24 21:00:20 +00:00
Stefano Ceccherini a1c0361478 Use LineHeight() instead of StyledWidthUTF8Safe() to get the height of
the line in PointAt(), since the former didn't return the correct 
result, due to the fact that there were 0 charachters on that line. 
Fixed a bug in TextHeight() which ended up doubling the 
height of the line if we requested the last line.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20745 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-18 09:33:32 +00:00
Stefano Ceccherini 2e2e58a452 The Mouse window is now centered if it's too close to the border of the
screen when shown (on start). Usually it was put in the top left corner 
on the screen when you first start it (very annoying).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20744 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-18 07:34:49 +00:00
Stefano Ceccherini 19ebf74dc6 Call RemoveToken() in the destructor
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20736 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-17 10:05:56 +00:00
Stefano Ceccherini 6dfe2237e6 Calling LockGL() before BGLView::AttachedToWindow() isn't allowed, it
seems, as it leads to a crash. The GLDirectMode test app now works.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20725 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-16 12:43:38 +00:00
Stefano Ceccherini 7e99a484fb Renamed *Dlg classes to *Window, completing my previous commit
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20680 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-13 16:41:44 +00:00
Stefano Ceccherini f8cc2a74e4 Renamed *Dlg to *Window, since the term "Dialog" is alien to the beos
api. Thanks to Vasilis Kaoutsis for the suggestion. I'll rename the 
classes with the next commit.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20679 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-13 16:35:50 +00:00
Stefano Ceccherini 22cf4a3be6 sizeof(B_PAGE_SIZE) != B_PAGE_SIZE. Fixed bug 1151. Sorry for the silly
typo. Also uses calloc() so that the direct_buffer_info struct is 
initialized to 0.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20663 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-12 13:15:06 +00:00
Stefano Ceccherini ba4918e74c Menu windows are no longer the preferred keyboard events target (for
now, at least). This feature wasn't used yet anyway, and turning it 
off cures bug #1152.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20662 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-12 12:28:13 +00:00
Stefano Ceccherini 41d7b9a54c Patch by Lucasz Zemczak which fixes font sensitiveness issues in Mouse
preflet. Thank you!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20659 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-11 21:06:35 +00:00
Stefano Ceccherini 5f2316263f Implemented BGLView::DirectConnected(). I don't know if it works, since
the gldirect_mode test app crashes at startup (also before this commit). 
Style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20636 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-04-10 14:11:32 +00:00
Stefano Ceccherini 63cd2925a0 Update the window size when adding and removing items. This fix bug
#683, but makes bug #582 look even more funny. Oh, well I hope I'll fix 
it one day.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20403 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-22 14:48:03 +00:00
Stefano Ceccherini a3d758e369 Added support for font settings in PictureDataWriter. Not used yet
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20381 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-13 11:14:47 +00:00
Stefano Ceccherini 2ef329a206 Fixed font sensitiveness issues in the Fonts preflet. Patch by Lucasz
Zemczak.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20379 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-12 20:52:21 +00:00
Stefano Ceccherini 96d6092ef6 Re-enabled wait_for_thread() (in place of kill_thread()) inside
TermParse's destructor. PtyReader() was hanging on read(), since the 
fd was never closed. Now we do that in ~TermWindow() (for now, we might 
want to move some stuff around). Moved there the cleanup code too (from 
TermWindow::Quit()). Use B_QUIT_ON_WINDOW_CLOSE flag instead of sending 
a message to be_app in Quit().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20335 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-05 14:59:37 +00:00
Stefano Ceccherini ff2184e07d temporary reverted to using kill_thread because of a deadlock on quit
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20334 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-05 13:14:12 +00:00
Stefano Ceccherini 63dc9cc262 Got rid of the global gPfd variable. Big time cleanup, made TermParse a
bit more robust with error checks and likes. Removed unused 
TermPrint.cpp file. I hope I didn't get on your 
way, Vasilis :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20333 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-05 12:48:36 +00:00
Stefano Ceccherini bb11b61bee Patch by Vasilis Kaoutsis:
* Use a BMessenger instead of a BWindow pointer
* Removed an useless SetTitle() call
* Lock the window before quitting it
* Style changes and cleanups


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20326 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-04 21:06:51 +00:00
Stefano Ceccherini 649d84071b Removed commented code which implemented reading and writing of old
style BPicture data. If we need to support it, we can always resurrect 
the code from the svn history.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20288 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 15:45:57 +00:00
Stefano Ceccherini 79e78d47e9 Moved some functions around, some minor cleanups...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20287 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 14:57:36 +00:00
Stefano Ceccherini ece074abe2 Archiving the picture now works
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20286 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 14:53:52 +00:00
Stefano Ceccherini caae1184ab When creating a picture with data, the app_server was writing beyond the
allocated memory, without telling anyone. That was causing bad things to 
happen. Flattening and unflattening BPictures now works, and 
consequently, printing works too. Bug #1014 is fixed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20285 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 14:47:10 +00:00
Stefano Ceccherini ccfc8a3dcb Archive the 2 pictures to a message, in order to compare the data.
Currently Archiving the Unflattened picture doesn't work, and it hangs 
inside assert_local_copy(), waiting for the app_server reply...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20280 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 13:19:05 +00:00
Stefano Ceccherini 3bf72bcb7c Unflattening the picture was obviously failing because we didn't rewind
the stream after Flattening. Now Unflattening works, but the picture 
seems to be empty


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20270 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 08:47:05 +00:00
Stefano Ceccherini 2d940ebc84 Flatten and Unflatten the BPicture before showing it. The picture
doesn't show up, that means something is still broken in Flatten() or 
Unflatten()


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20267 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 07:45:50 +00:00
Stefano Ceccherini 3e837bf6d0 Patch by Vasilis Kaoutsis:
* Style issues.
* Renamed CenteredRect to _CenteredRect
since is private and removed the static keyword.
* Corrected copyright dates.
Thank you!



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20266 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-01 07:20:06 +00:00
Stefano Ceccherini 3834597b97 Another patch by Vasilis Kaoutsis: Replaced pointer use with a
BMessenger


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20238 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-26 16:18:44 +00:00
Stefano Ceccherini 11ef32dfa9 erase() shrinks the vector, so we decrement the handler. Fixes the crash in case there are invalid handlers (Time application, for example). Should be fixed in the other _SendNotices() call too ?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20183 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 16:25:15 +00:00
Stefano Ceccherini e44561b2e9 even more style changes
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20182 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 14:50:40 +00:00
Stefano Ceccherini 53596257db more cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20180 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 14:22:38 +00:00
Stefano Ceccherini 4fe138eecb Removed a goto, style changes, patch by Vasilis Kaoutsis. Thank you!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20179 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 13:04:26 +00:00
Stefano Ceccherini 355c6ebe10 fixed some style issues introduced with the latest patch
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20178 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 12:52:18 +00:00
Stefano Ceccherini 470523054d removed unused files
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20177 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 06:55:44 +00:00
Stefano Ceccherini 5065a78576 cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20176 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-20 06:51:26 +00:00
Stefano Ceccherini f082d94258 patch by Vasilis Kaoutsis: removed the use of goto
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20147 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-17 13:35:40 +00:00
Stefano Ceccherini 66ab330ddd Added Andrea Anzani to the list of contributors
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20120 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-09 12:24:56 +00:00
Stefano Ceccherini 69d0d14914 Patch by Andrea Anzani which fixes font sensitiveness issues with
Expander preferences window (thus fixing bug #162). Some cleanups by me


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20119 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-09 12:19:43 +00:00
Stefano Ceccherini e32034330f Added FontDemo (not really working well) and moved Clock to Demos
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20118 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-09 11:44:53 +00:00
Stefano Ceccherini d619599aa3 some more forgotten style changes
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20117 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-02-09 10:29:13 +00:00
Stefano Ceccherini b30e7f31c1 Use BTextView::Copy/FreeRunArray() instead of memcpy() and free()
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19938 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-24 06:11:12 +00:00
Stefano Ceccherini 1a64df767e BTextView::FreeRunArray() now accepts a NULL pointer too (like free())
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19937 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-24 06:02:58 +00:00
Stefano Ceccherini 4446e07ae9 Use BMenu::RemoveItems() instead of looping... I hope I caught all
occurrences.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19910 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-23 11:22:12 +00:00
Stefano Ceccherini 68fb266820 get rid of the now useless trackTime parameter
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19828 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-16 15:22:31 +00:00
Stefano Ceccherini ebd1a3a130 some more work on menus... fixed bug #953 and some more stuff
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19827 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-16 14:43:01 +00:00
Stefano Ceccherini ee144512ec use Invalidate() and UpdateIfNeeded() in BTextView::SetTextRect(). Fixes bug #571
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19824 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-16 09:04:14 +00:00
Stefano Ceccherini 1e634f4d9c Actually use B_COLOR_SELECTION_TEXT when drawing. Patch by Andrea Anzani
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19823 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-16 08:36:35 +00:00
Stefano Ceccherini 27e7210df2 Since Waldemar changes to menus, replicants menus didn't work
anymore. That problem showed up for example during my haiku 
presentation at Begeistert, where I couldn't delete replicants from 
the desktop... grrrr!!! :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19708 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-05 10:03:33 +00:00
Stefano Ceccherini d5ff520ac3 don't copy fortune folder to the image (temporarily), since latest change prevented it to be copied anyway, and also other files weren't copied then (termcap, teapot.data, profile), because 'fortune' is a folder now, and not a file anymore. Please someone fix this
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19707 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-05 08:42:04 +00:00
Stefano Ceccherini 436bc5cc51 Menuwindow was 10 pixels away from the screen bottom when scrolling was
enabled.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19706 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-05 08:23:09 +00:00
Stefano Ceccherini 25df172b72 Implemented auto horizontal scrolling (by fixed steps for now), moved
auto scrolling to its own method, introduced a new private 
StyledWidthUTF8Safe method.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19694 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-04 10:44:29 +00:00
Stefano Ceccherini 23fb6e0efe - Fixed wrong redrawing of the caret in some particular circumstancies
(most notably when you clicked the first time on the textview, the caret 
would be left "drawn" on the old position.
- Implemented vertical auto scrolling (horizontal auto scrolling is 
still missing). Note that the view jumps when there is nothing to 
scroll, might be a bug in BView::ScrollBy() ?
 


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19692 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-04 09:40:54 +00:00
Stefano Ceccherini 83c6772dc8 extended a comment and added a new one
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19688 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-03 07:43:14 +00:00
Stefano Ceccherini ae9aed772e in case of error, set buttons to 0, for real
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19687 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-03 07:35:31 +00:00
Stefano Ceccherini 52924c5ef9 Removed different menu separators
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19686 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-03 07:04:01 +00:00
Stefano Ceccherini 13b0cc8c5d now returns 1 in case of error, not -1, as Korli asked.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19676 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-01-02 07:03:11 +00:00
Stefano Ceccherini f5e5e36026 forgot to fix this small style issue
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19654 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-29 07:09:16 +00:00
Stefano Ceccherini c733893846 Greatly improved scrolling, and simplified the code too. Now scrolling
is done from inside the BMenu::_track() function, and not inside Pulse() 
anymore. Patch by Lucasz Zemczak


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19653 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-29 07:01:08 +00:00
Stefano Ceccherini 191732a41c another small style patch by Vasilis Kaoutsis
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19652 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-29 06:47:12 +00:00
Stefano Ceccherini dace9db1ef Patch by Andrea Anzani for some visual glitches:
- separation lines weren't drawn correctly if the CLV was scrolled horizontally.
- in some cases, when unhilighting an item, the item itself werent' 
drawn correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19603 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-22 08:47:49 +00:00
Stefano Ceccherini f3011ac047 applied style patch by Vasilis Kaoutsis
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19602 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-22 08:19:00 +00:00
Stefano Ceccherini 422f8ec3ee applied style patch by Vasilis Kaoutsis
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19601 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-22 08:17:16 +00:00
Stefano Ceccherini 6e194a72e7 only lock after checking the other conditions. Also changed iteration
to remove menu items with a single RemoveItems() call. Axel, I hope you 
don't mind.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19600 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-22 07:34:05 +00:00
Stefano Ceccherini f0f8601b3f small cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19591 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-21 14:35:13 +00:00
Stefano Ceccherini 59f9192c3b added nothrow
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19590 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-21 14:34:58 +00:00
Stefano Ceccherini 9f0ebbfcda Call Window()->Show() in DetachedFromWindow() only if we were dragging, thus correctly mirroring what done in AttachedToWindow(). This caused the empty menu window in deskbar (trac is down, can't remember the right bug number), but I don't know why it happened only in haiku. Maybe in beos the looper->Lock() call never succeeded, due to slightly different locking strategy ? Axel, could you review this change ?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19589 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-21 14:32:22 +00:00
Stefano Ceccherini 8b91b40ae6 Try to split the tracking function into smaller ones. Please bear with
me for the absolutely UGLY names. Also, if someone can suggest better 
ones...
I seem not to have introduced any new bug. 


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19476 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-12 16:05:16 +00:00
Stefano Ceccherini cd1cef8aab moved synchronous waiting to _WaitMenu(). Renamed private methods to our
style guidelines.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19475 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-12 14:49:32 +00:00
Stefano Ceccherini e1e8ce6bf1 removed weird charachters at the end of the file
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19472 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-12 13:03:06 +00:00
Stefano Ceccherini 4a765b5f26 moved some variables around
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19457 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-11 15:58:29 +00:00
Stefano Ceccherini f2b50593a8 renamed pfd to gPfd as it's a global variable, fixed indentation in
TermView.cpp, other style changes


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19455 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-11 11:13:06 +00:00
Stefano Ceccherini 08d9291667 removed now unneded extra Draw() call used as a workaround to broken
scrolling.
Menu attached to menubars now use scrolling if they are opened near the 
bottom of the screen (just like in beos). I'm not sure if this is so 
nice, though, so it could be reverted. Patch contributed by Lucasz 
Zemczak


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19442 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-07 11:25:24 +00:00
Stefano Ceccherini b19041249d got rid of the tty_name global
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19441 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-07 11:23:31 +00:00
Stefano Ceccherini f17a85d17d set the extrarect also for menubars (but it's not yet used)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19434 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-05 13:53:51 +00:00
Stefano Ceccherini 8071d85b5a fixed the build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19433 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-05 13:34:14 +00:00
Stefano Ceccherini a675fc2864 Let go what I said about bug #890. This was the real problem
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19420 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-04 15:37:51 +00:00
Stefano Ceccherini d75bff02b3 fixed the build under haiku
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19404 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-12-01 08:25:48 +00:00
Stefano Ceccherini f9e5811b92 forgot this file
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19380 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-11-28 14:57:37 +00:00
Stefano Ceccherini 0c48fc7c74 Enable state synching for ServerPictures. Fixes bug 520
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19379 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-11-28 14:52:51 +00:00
Stefano Ceccherini 64a74d5eff close the menu immediately when user clicks outside the menu
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19366 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-11-23 21:39:49 +00:00
Stefano Ceccherini e0fcf72ae0 Fixed some semi-random crashes in deskbar and tracker caused by the new scrolling code. patch by Lucasz Zemczak. Also now the menu tracking function checks the result of the userdefined tracking hook, thus fixing bug #938
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19348 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-11-21 14:54:44 +00:00
Stefano Ceccherini e733c6856a Fixed bug 931 by using a different construct to redirect both stderr and
stdout to /dev/null


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19345 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-11-20 20:45:06 +00:00